From owner-freebsd-multimedia@FreeBSD.ORG Mon May 30 03:25:24 2005 Return-Path: X-Original-To: freebsd-multimedia@freebsd.org Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1DD516A41C for ; Mon, 30 May 2005 03:25:24 +0000 (GMT) (envelope-from yongari@rndsoft.co.kr) Received: from rndsoft.co.kr (michelle.rndsoft.co.kr [211.32.202.209]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5758843D48 for ; Mon, 30 May 2005 03:25:24 +0000 (GMT) (envelope-from yongari@rndsoft.co.kr) Received: by simscan 1.1.0 ppid: 10885, pid: 10886, t: 1.1565s scanners:none Received: from unknown (HELO michelle.rndsoft.co.kr) (192.168.5.90) by 0 with SMTP; 30 May 2005 03:22:50 +0900 Received: from michelle.rndsoft.co.kr (localhost.rndsoft.co.kr [127.0.0.1]) by michelle.rndsoft.co.kr (8.13.1/8.13.1) with ESMTP id j4U3Mxql001574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 30 May 2005 12:22:59 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Received: (from yongari@localhost) by michelle.rndsoft.co.kr (8.13.1/8.13.1/Submit) id j4U3Mxw6001573; Mon, 30 May 2005 12:22:59 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Date: Mon, 30 May 2005 12:22:58 +0900 From: Pyun YongHyeon To: Scott Long Message-ID: <20050530032258.GD892@rndsoft.co.kr> References: <20050527062200.GA17663@rndsoft.co.kr> <4297382A.3060505@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4297382A.3060505@samsco.org> User-Agent: Mutt/1.4.2.1i X-Spam-Checker-Version: SpamDetector 1.00 (2004-01-11) on Cc: freebsd-multimedia@freebsd.org Subject: Re: maestro3 hardware volume control X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: yongari@rndsoft.co.kr List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2005 03:25:25 -0000 On Fri, May 27, 2005 at 09:09:30AM -0600, Scott Long wrote: > Pyun YongHyeon wrote: > >Hi, > > > >I noticed hardware volume control of maestro3 didn't work. With > >small patch it worked on my system(Gateway Solo 5300). > > > >Hardware volume control of maestro3 can be configured with two > >different control pins. Unfortunately it seems that it's hard to > >know which control pin was wired to control the volume. > >At present maestro3 provides a way via hint file to select one of > >the two configurations. > > > >hint.pcm.0.hwvol_config="0" : select GD(game port interface) pin 6, 7 > >hint.pcm.0.hwvol_config="1" : select GPIO pin 4,5 > >If there is no hint the driver select GD pin 6, 7. > > > >In my system selecting GD pins didn't work and a comment at the > >beginning of the driver source indicates it didn't ever work. So I'd > >like to change to select GPIO pins as a default hardware volume > >control. For users needs to select GD pins it could be easily done > >with hint.pcm.0.hwvol_config="0" in /boot/device.hints file. > >But I think there are no such users since device.hints file had no > >such entry. > > > > I believe that the source comment was out of date. It certainly worked Thanks for clarifying that. > when I wrote the code (see rev 1.11). However, you're doing a much > better job of maintaining this driver than I, so you're welcome to > change it as you see fit. Make sure that it gets documented, though. > Since there are systems that work with current driver's behavior I wouldn't change the driver. But I'll update document. -- Regards, Pyun YongHyeon http://www.kr.freebsd.org/~yongari | yongari@freebsd.org