Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Jun 2012 06:29:12 +0900
From:      Taku YAMAMOTO <taku@tackymt.homeip.net>
To:        Poul-Henning Kamp <phk@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r237203 - head/sys/dev/fb
Message-ID:  <20120618062912.61088c11.taku@tackymt.homeip.net>
In-Reply-To: <201206172102.q5HL2mG9032399@svn.freebsd.org>
References:  <201206172102.q5HL2mG9032399@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 17 Jun 2012 21:02:48 +0000 (UTC)
Poul-Henning Kamp <phk@FreeBSD.org> wrote:

> Author: phk
> Date: Sun Jun 17 21:02:48 2012
> New Revision: 237203
> URL: http://svn.freebsd.org/changeset/base/237203
(snip)
> Modified:
>   head/sys/dev/fb/fbreg.h
> 
> Modified: head/sys/dev/fb/fbreg.h
> ==============================================================================
> --- head/sys/dev/fb/fbreg.h	Sun Jun 17 20:45:45 2012	(r237202)
> +++ head/sys/dev/fb/fbreg.h	Sun Jun 17 21:02:48 2012	(r237203)
> @@ -35,9 +35,16 @@
>  
>  /* some macros */
>  #if defined(__amd64__) || defined(__i386__)
> -#define bcopy_io(s, d, c)	bcopy((void *)(s), (void *)(d), (c))
> -#define bcopy_toio(s, d, c)	bcopy((void *)(s), (void *)(d), (c))
> -#define bcopy_fromio(s, d, c)	bcopy((void *)(s), (void *)(d), (c))
> +
> +static __inline void
> +copyw(uint16_t *src, uint16_t *dst, size_t size)
> +{
> +	while (size--)
> +		*dst++ = *src++;
> +}
> +#define bcopy_io(s, d, c)	copyw((void*)(s), (void*)(d), (c))
> +#define bcopy_toio(s, d, c)	copyw((void*)(s), (void*)(d), (c))
> +#define bcopy_fromio(s, d, c)	copyw((void*)(s), (void*)(d), (c))
>  #define bzero_io(d, c)		bzero((void *)(d), (c))
>  #define fill_io(p, d, c)	fill((p), (void *)(d), (c))
>  #define fillw_io(p, d, c)	fillw((p), (void *)(d), (c))
> 

Does this end up with copying 2*size bytes instead of size bytes?

-- 
-|-__   YAMAMOTO, Taku
 | __ <     <taku@tackymt.homeip.net>

      - A chicken is an egg's way of producing more eggs. -



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120618062912.61088c11.taku>