From owner-dev-commits-src-all@freebsd.org Wed Mar 3 12:54:01 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 703FE569D6B; Wed, 3 Mar 2021 12:54:01 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DrDTP0ds8z3j4B; Wed, 3 Mar 2021 12:54:00 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 123Crxav051358; Wed, 3 Mar 2021 04:53:59 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 123CrxKG051357; Wed, 3 Mar 2021 04:53:59 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202103031253.123CrxKG051357@gndrsh.dnsmgr.net> Subject: Re: git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in 0b7472b3d8d2. In-Reply-To: <63ccc815-d23b-44f5-8bf8-d301ce0665f7@www.fastmail.com> To: Brandon Bergren Date: Wed, 3 Mar 2021 04:53:59 -0800 (PST) CC: Ed Maste , Warner Losh , Nathan Whitehorn , "Rodney W. Grimes" , src-committers , "" , dev-commits-src-main@FreeBSD.org Reply-To: rgrimes@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4DrDTP0ds8z3j4B X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 12:54:01 -0000 > OK, how about this as an idea then: > > Parse mount output to see if anything is mounted to /boot/efi directly? > > if mount -p | cut -f 2 | grep '^/boot/efi$'; then > .... > fi What am I missing here? One place I am being told this is run in an environment that may not even be an EFI booted system, and in another place it is being used as a test if something is mounted on it, which should only be true on an EFI booted system. Using the existance of a directory or something mounted on that directory is probably one of the worse ways to make a decsiion about if the system is or is not EFI capable, or if it needs or doesnt need EFI support stuff. I often boot from a MBR sd card or usb memstick and install an EFI system on another type of media. I am sure there is stuff in the release process that has to make EFI related platform issues, and that should probably be controled by a platform specific MK_foo knob, and not by these "exists" tests. > Brandon Bergren > bdragon@FreeBSD.org -- Rod Grimes rgrimes@freebsd.org