From owner-freebsd-current@FreeBSD.ORG Sat Aug 10 21:47:22 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 51865560 for ; Sat, 10 Aug 2013 21:47:22 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E15CD22D7 for ; Sat, 10 Aug 2013 21:47:21 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.7/8.14.7/ALCHEMY.FRANKEN.DE) with ESMTP id r7ALlKZL060731; Sat, 10 Aug 2013 23:47:20 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.7/8.14.7/Submit) id r7ALlJWX060730; Sat, 10 Aug 2013 23:47:19 +0200 (CEST) (envelope-from marius) Date: Sat, 10 Aug 2013 23:47:19 +0200 From: Marius Strobl To: Scott Long Subject: Re: CFT: PCI Command Register fixups Message-ID: <20130810214719.GA60616@alchemy.franken.de> References: <5E12B1A6-5B39-46FE-B8C7-239D23AEEE5E@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5E12B1A6-5B39-46FE-B8C7-239D23AEEE5E@samsco.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "current@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Aug 2013 21:47:22 -0000 On Fri, Aug 09, 2013 at 09:56:48PM -0600, Scott Long wrote: > All, > > Subversion rev 250418 affected approximately 63 drivers by making them vulnerable to resource allocation failures on motherboards with buggy BIOSes. The revision itself is good, but it needs to address these drivers and bring them up to what is, in effect, a modified way for drivers to manage their PCI resources. If you've been seeing something like the following message since June 24/27, then you need this patch: > > mps0: port 0xd000-0xd0ff mem 0xfb79c000-0xfb79ffff irq 19 at device 0.0 on pci4 > mps0: PCI memory window not available > device_attach: mps0 attach returned 6 > > The patch originated from John Baldwin, I merely fixed up a few nits and am passing it around for review and testing. Please find it here: > > http://people.freebsd.org/~scottl/pci_command_fixes.patch > In mpt_pci.c, there's a style nit/inconsistency regarding the other drivers touched by the above patch; if after these fixes, a driver still fiddles with PCIR_COMMAND, it should be just fine to also OR in PCIM_CMD_BUSMASTEREN as part of that and to not additionally call pci_enable_busmaster(). Apart from that, the patch looks good to me. Marius