Date: Wed, 26 Jul 2023 14:30:11 GMT From: Konstantin Belousov <kib@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: a24726a6f3b4 - main - rtld_malloc: remove outdated comments Message-ID: <202307261430.36QEUBKu026505@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=a24726a6f3b43473093267e2b4e81d186817dc7d commit a24726a6f3b43473093267e2b4e81d186817dc7d Author: Konstantin Belousov <kib@FreeBSD.org> AuthorDate: 2023-07-22 04:13:58 +0000 Commit: Konstantin Belousov <kib@FreeBSD.org> CommitDate: 2023-07-26 14:24:17 +0000 rtld_malloc: remove outdated comments The ovu_magic is not neccessary overlaps with low byte of the ov_next, for the big endian machines. There is no range checking in the allocator. Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D41150 --- libexec/rtld-elf/rtld_malloc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libexec/rtld-elf/rtld_malloc.c b/libexec/rtld-elf/rtld_malloc.c index d08254b67d9f..0eec68f35402 100644 --- a/libexec/rtld-elf/rtld_malloc.c +++ b/libexec/rtld-elf/rtld_malloc.c @@ -68,10 +68,6 @@ static caddr_t pagepool_start, pagepool_end; * contains a pointer to the next free block, and the bottom two bits must * be zero. When in use, the first byte is set to MAGIC, and the second * byte is the size index. The remaining bytes are for alignment. - * If range checking is enabled then a second word holds the size of the - * requested block, less 1, rounded up to a multiple of sizeof(RMAGIC). - * The order of elements is critical: ov_magic must overlay the low order - * bits of ov_next, and ov_magic can not be a valid ov_next bit pattern. */ union overhead { union overhead *ov_next; /* when free */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307261430.36QEUBKu026505>