From owner-dev-commits-ports-all@freebsd.org  Wed Sep  8 08:35:35 2021
Return-Path: <owner-dev-commits-ports-all@freebsd.org>
Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4A1D9677231;
 Wed,  8 Sep 2021 08:35:35 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4H4Fnz1Lnmz4tYG;
 Wed,  8 Sep 2021 08:35:35 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
 t=1631090135;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=4X81HNSgeWOhXVN/QUWShYPmCjgBdHNTOk/8X/Y5CPs=;
 b=sTlWzygv3CV0b/8PF+Dw6O9/G/9NUx41T1M529NvXBNkjAqT3EJntykQQCATDWbWe+rQUZ
 OdCbQm5nE5rsSuYFdQKOD9eKIS9AtvoD3dsvl5xsnQZYFIgJJli/B0dXotqRAGacWZYw/7
 uqdiEp8XxftaFi41Pp+oFFMcut1FTqSaNMmqGSMaRSgHyPS5EAzZlzzv0y+PecqW3H48hP
 KZy1ztalx2UKvFNzYPhEyFK0AQjfRmtU1vrscUNlkfBa1wXtbtvr/DBMn9sfWrWF5su+I9
 B446pTgo1N33RzmaPxN3cJsI6gyPsHqte53i9Orj+XulM1F22xs3oCILDC/p7Q==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 1957C917A; Wed,  8 Sep 2021 08:35:35 +0000 (UTC)
Date: Wed, 8 Sep 2021 08:35:35 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Adriaan de Groot <adridg@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
 dev-commits-ports-main@freebsd.org
Subject: Re: git: c04e85e180e5 - main - graphics/luminance-qt5: adjust Eigen
 dependency
Message-ID: <YTh118W/v7kbpLXq@FreeBSD.org>
References: <202109080828.1888SmeA017351@gitrepo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202109080828.1888SmeA017351@gitrepo.freebsd.org>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
 s=dkim; t=1631090135;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=4X81HNSgeWOhXVN/QUWShYPmCjgBdHNTOk/8X/Y5CPs=;
 b=Az1IDG8g2HhW9BZBUwwKIuikk10cs8mLmYFK+Awd8LCnmgg4iECYvGprROOaPPgfzqXfPy
 ACSqx0+2w2tqsKT+kVAXhnvhOf0AY2O6bnmuP9B67deEb7wAmvVGFJpbPJj1wJEbAhCyCz
 26zA0bpv7CrsnL+ZTvxUcaDfyMMYnJSmHnoyC9RDuHWclNNZYWky7ipilGUx26zKcUtMDh
 5Sy4+UxziiGw4Z2KMqGHkgdK0D6z7LeKd+RBbrL5jtYgbwpB11YHVe0nHLZMcRX4ACtxM4
 12WW1PNVk6WpHci4z3wDTNtQ1AOnKjEZFl47Lo4sYpTA4+VokRx4grQaAGP2jA==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1631090135; a=rsa-sha256; cv=none;
 b=dHPOJoILQVmTwRaZHIn4T7brc7aYEuCFdH81EM8nJv1NEcn+mJ0tAxnnVLt4u8ijKePM9W
 UGNbCVa19Zk46nGk8pDswDPiPXq3pfA8BpLf1KBbUDEXijDxaoswYOqgqcnGZXP7EOYYGl
 I4G4NLsWzUjiemfd9Ur+lDvl3QgQKFIYGdXNmUONmoScmEtjW7ZgsT0TlhZgXRQDvOXxSH
 Ll4MM+F3mDQ0FKypvP4As934Hx+iuA6Dr+VByICqOiV7WutuSdoUj8g7+3i8widDC9s4ZM
 wWRLxstkaz5CTG5Fk1pyzpdk+61j/n6h+b9o/ImfhbHu4ZnEBTvbVkeW2xNsqQ==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-BeenThere: dev-commits-ports-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the ports repository
 <dev-commits-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Help: <mailto:dev-commits-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Sep 2021 08:35:35 -0000

On Wed, Sep 08, 2021 at 08:28:48AM +0000, Adriaan de Groot wrote:
> commit c04e85e180e566fa830b63a3506d919e04ac4bc5
> 
>     graphics/luminance-qt5: adjust Eigen dependency
>     
>     - get Eigen via USES
>     - adjust CMake helpers while here
>  
> -OPTIONS_DEFINE=	CFITSIO DOCS HELPBROWSER
> +OPTIONS_DEFINE=		CFITSIO DOCS HELPBROWSER
>  OPTIONS_DEFAULT=	CFITSIO HELPBROWSER
>  
>  CFITSIO_LIB_DEPENDS=	libcfitsio.so:astro/cfitsio
>  
>  HELPBROWSER_DESC=	Build help browser (requires QtWebEngine)
>  HELPBROWSER_USE=	QT=webchannel,webengine
> -HELPBROWSER_CMAKE_ON=	-DWITH_HELPBROWSER:BOOL=ON
> +HELPBROWSER_CMAKE_ON=	WITH_HELPBROWSER

This is wrong, I think you're confusing CMAKE_ON and SOME_OPTION_CMAKE_ON.

./danfe