From owner-freebsd-questions@FreeBSD.ORG  Wed Feb  1 17:00:17 2006
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
X-Original-To: freebsd-questions@freebsd.org
Delivered-To: freebsd-questions@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F0ABC16A423;
	Wed,  1 Feb 2006 17:00:16 +0000 (GMT) (envelope-from past@ebs.gr)
Received: from fly.ebs.gr (dslcustomer-239-113.vivodi.gr [83.171.239.113])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1BE6B43D49;
	Wed,  1 Feb 2006 17:00:14 +0000 (GMT) (envelope-from past@ebs.gr)
Received: from ebs.gr (root@hal.ebs.gr [10.1.1.2])
	by fly.ebs.gr (8.12.9p1/8.12.9) with ESMTP id k11H01Sg021875;
	Wed, 1 Feb 2006 19:00:01 +0200 (EET) (envelope-from past@ebs.gr)
Received: from [10.1.1.158] (ajax.ebs.gr [10.1.1.158])
	by ebs.gr (8.13.3/8.12.11) with ESMTP id k11H0k7o067124;
	Wed, 1 Feb 2006 19:00:46 +0200 (EET) (envelope-from past@ebs.gr)
Message-ID: <43E0E908.7010603@ebs.gr>
Date: Wed, 01 Feb 2006 18:59:52 +0200
From: Panagiotis Astithas <past@ebs.gr>
Organization: EBS Ltd.
User-Agent: Thunderbird 1.5 (X11/20060116)
MIME-Version: 1.0
To: Stijn Hoop <stijn@win.tue.nl>, Anish Mistry <mistry.7@osu.edu>,
	Mark Kane <mark@mkproductions.org>, gnome@freebsd.org,
	Frank Staals <frankstaals@gmx.net>, freebsd-questions@freebsd.org,
	Simon Barner <barner@freebsd.org>
References: <a8b370910601262206p2dea460fj87b097fadaa3372b@mail.gmail.com>	<200601271218.00377.mistry.7@osu.edu>	<43DA7946.6000100@mkproductions.org>	<200601271850.21187.mistry.7@osu.edu>	<20060128163501.GA68709@pcwin002.win.tue.nl>
	<20060128203524.GB68709@pcwin002.win.tue.nl>
In-Reply-To: <20060128203524.GB68709@pcwin002.win.tue.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Wed, 01 Feb 2006 17:11:50 +0000
Cc: 
Subject: Re: Firefox 1.5
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
	<mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
	<mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Feb 2006 17:00:17 -0000

Stijn Hoop wrote:
> For those interested, paste the inline patch below in
> 
> /usr/ports/www/firefox/files/patch-bugzilla305970
> 
> And reinstall your firefox. Thanks again, Anish, it certainly seemed to
> help me!
> 
> --Stijn
> 
> --- widget/src/gtk2/nsWindow.cpp.orig	Thu Aug 18 10:11:23 2005
> +++ widget/src/gtk2/nsWindow.cpp	Sat Jan 28 18:34:03 2006
> @@ -148,9 +148,9 @@
>                                             GdkEventVisibility *event);
>  static gboolean window_state_event_cb     (GtkWidget *widget,
>                                             GdkEventWindowState *event);
> -static void     style_set_cb              (GtkWidget *widget,
> -                                           GtkStyle *previous_style,
> -                                           gpointer data);
> +static void     theme_changed_cb          (GtkSettings *settings,
> +                                           GParamSpec *pspec,
> +                                           nsWindow *data);
>  #ifdef __cplusplus
>  extern "C" {
>  #endif /* __cplusplus */
> @@ -372,6 +372,10 @@
>      mIsDestroyed = PR_TRUE;
>      mCreated = PR_FALSE;
>  
> +    g_signal_handlers_disconnect_by_func(gtk_settings_get_default(),
> +                                         (gpointer)G_CALLBACK(theme_changed_cb),
> +                                         this);
> +
>      // ungrab if required
>      nsCOMPtr<nsIWidget> rollupWidget = do_QueryReferent(gRollupWindow);
>      if (NS_STATIC_CAST(nsIWidget *, this) == rollupWidget.get()) {
> @@ -2434,8 +2438,16 @@
>                           G_CALLBACK(delete_event_cb), NULL);
>          g_signal_connect(G_OBJECT(mShell), "window_state_event",
>                           G_CALLBACK(window_state_event_cb), NULL);
> -        g_signal_connect(G_OBJECT(mShell), "style_set",
> -                         G_CALLBACK(style_set_cb), NULL);
> +
> +        g_signal_connect_after(gtk_settings_get_default(),
> +                               "notify::gtk-theme-name",
> +                               G_CALLBACK(theme_changed_cb), this);
> +        g_signal_connect_after(gtk_settings_get_default(),
> +                               "notify::gtk-key-theme-name",
> +                               G_CALLBACK(theme_changed_cb), this);
> +        g_signal_connect_after(gtk_settings_get_default(),
> +                               "notify::gtk-font-name",
> +                               G_CALLBACK(theme_changed_cb), this);
>      }
>  
>      if (mContainer) {
> @@ -3916,11 +3928,9 @@
>  
>  /* static */
>  void
> -style_set_cb (GtkWidget *widget, GtkStyle *previous_style, gpointer data)
> +theme_changed_cb (GtkSettings *settings, GParamSpec *pspec, nsWindow *data)
>  {
> -    nsWindow *window = get_window_for_gtk_widget(widget);
> -    if (window)
> -        window->ThemeChanged();
> +    data->ThemeChanged();
>  }
>  
>  //////////////////////////////////////////////////////////////////////


This has made firefox a pleasure to use again for me.

Thanks,

Panagiotis