Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Sep 2019 16:52:53 +0000
From:      "Sergey A. Osokin" <osa@freebsd.org>
To:        "Herbert J. Skuhra" <herbert@gojira.at>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r512184 - in head/www/nginx-devel: . files
Message-ID:  <20190924165253.GI12076@FreeBSD.org>
In-Reply-To: <20190920161922.GB58875@mail.bsd4all.net>
References:  <201909162038.x8GKcLoD070077@repo.freebsd.org> <87v9toaxaq.wl-herbert@gojira.at> <20190920122908.GG12076@FreeBSD.org> <20190920132055.GA58875@mail.bsd4all.net> <20190920133048.GH12076@FreeBSD.org> <20190920161922.GB58875@mail.bsd4all.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 20, 2019 at 06:19:22PM +0200, Herbert J. Skuhra wrote:
> On Fri, Sep 20, 2019 at 01:30:48PM +0000, Sergey A. Osokin wrote:
> > On Fri, Sep 20, 2019 at 03:20:55PM +0200, Herbert J. Skuhra wrote:
> > > On Fri, Sep 20, 2019 at 12:29:08PM +0000, Sergey A. Osokin wrote:
> > > > On Thu, Sep 19, 2019 at 09:41:33PM +0200, Herbert J. Skuhra wrote:
> > > > > On Mon, 16 Sep 2019 22:38:21 +0200, "Sergey A. Osokin" wrote:
> > > > > > 
> > > > > > Author: osa
> > > > > > Date: Mon Sep 16 20:38:21 2019
> > > > > > New Revision: 512184
> > > > > > URL: https://svnweb.freebsd.org/changeset/ports/512184
> > > > > > 
> > > > > > Log:
> > > > > >   Add the following third-party modules:
> > > > > >   o) ip2location
> > > > > >   o) ip2proxy
> > > > > >   
> > > > > >   Add third-party slice_ahead feature.
> > > > > >   
> > > > > >   Update third-party passenger module to the latest release 6.0.3.
> > > > > >   
> > > > > >   Switch third-party lua module dependence from lang/luajit (2.0) to
> > > > > >   lang/luajit-openresty (2.1).
> > > > > >   
> > > > > >   Bump PORTREVISION.
> > > > > > 
> > > > > > Modified:
> > > > > >   head/www/nginx-devel/Makefile
> > > > > >   head/www/nginx-devel/Makefile.extmod
> > > > > >   head/www/nginx-devel/Makefile.options.desc
> > > > 
> > > > > >   head/www/nginx-devel/distinfo
> > > > > >   head/www/nginx-devel/files/extra-patch-passenger-build-nginx.rb
> > > > > >   head/www/nginx-devel/files/extra-patch-passenger-disable-telemetry
> > > > > 
> > > > > This commit is obviously wrong/incomplete:
> > > > > 
> > > > > 1. option HTTP_SLICE_AHEAD was added in wrong place
> > > > > 2. extra-patch-src_http_modules_ngx_http_slice_read_ahead.c is missing
> > > > 
> > > > Hi Herbert,
> > > > 
> > > > thanks for point me in.  The missing patch has been found and added
> > > > to the port.
> > > > Could you please explain what does it mean HTTP_SLICE_AHEAD in a wrong
> > > > place.
> > > 
> > > Hi Sergey,
> > > 
> > > thanks.
> > > 
> > > HTTP_SLICE_AHEAD is an external module but the option was added to
> > > "Modules that are part of the base nginx distribution".
> > 
> > Got it, Herbert, here is the patch.
> 
> Thanks. Looks good but I think the PORTVERSION bump is not really
> needed, is it?

Committed, thanks for the report, Herbert!

-- 
Sergey



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190924165253.GI12076>