From owner-svn-src-all@freebsd.org Fri Jan 3 00:35:58 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C50291E0F82; Fri, 3 Jan 2020 00:35:58 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47pmCx4zxVz4D4w; Fri, 3 Jan 2020 00:35:57 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 44E733C0199; Fri, 3 Jan 2020 00:35:51 +0000 (UTC) Date: Fri, 3 Jan 2020 00:35:51 +0000 From: Brooks Davis To: Kyle Evans Cc: src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r355936 - in head/sys: arm/broadcom/bcm2835 arm/freescale/imx arm/ti/am335x arm/versatile powerpc/ofw Message-ID: <20200103003551.GH91104@spindle.one-eyed-alien.net> References: <201912201622.xBKGMEdl019516@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 47pmCx4zxVz4D4w X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-6.52 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; IP_SCORE(-3.62)[ip: (-9.48), ipnet: 199.48.128.0/22(-4.73), asn: 36236(-3.84), country: US(-0.05)]; TO_DN_ALL(0.00)[]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2020 00:35:58 -0000 --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 23, 2019 at 03:14:07PM -0600, Kyle Evans wrote: > On Fri, Dec 20, 2019 at 10:22 AM Kyle Evans wrote: > > > > Author: kevans > > Date: Fri Dec 20 16:22:14 2019 > > New Revision: 355936 > > URL: https://svnweb.freebsd.org/changeset/base/355936 > > > > Log: > > Kill off dummy kbd drivers > > > > As far as I can tell, these are an artifact of times when linker sets > > couldn't be empty, otherwise the kernel build would fail due to unres= olved > > symbols. hselasky fixed this in r268138, and I've audited the kbd por= tions > > to make sure nothing would blow up due to the empty linker set and > > successfully compiled+ran a kernel with no keyboard support at all. > > > > Kill them off now since they're no longer required. > > > > MFC after: 1 week > > >=20 > It turns out that I missed one of these in > ^/sys/dev/terasic/mtl/terasic_mtl_syscons.c, which has the following > note that shows my analysis to be not inaccurate but incorrect: >=20 > /* > * XXXRW: For historical reasons, syscons can't register video consoles > * without a keyboard implementation. Provide a dummy. > */ >=20 > As far as I can tell, this isn't the case anymore as sckbdprobe's > return value is ignored and other references to the keyboard appear to > be properly gated on sc->keyboard being valid. >=20 > I only have a single machine that can run syscons, but I built a > kernel with the same modifications to remove all of the keyboard > drivers (-ukbd, kbdmux, hyperv) for that machine and encountered no > problems in practice. >=20 > I will proceed with removing the last dummy driver and MFC as scheduled. That's fine. I doubt anyone but us (CHERI) uses the Terasic MTL driver. -- Brooks --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeDoxmAAoJEKzQXbSebgfApPoH/3WQNDoh8GXo0cH9HA2fnsdw i8AB+7iOiF+py2UootR3zTRJczhk1CrgOmbeo3I8NR1skdqi7m9Pw/FYNjTiUkeJ 50gdMQCSj0xUnt3/csqh5aAasQUiKiuvucG3xSfypbRIR4fVzFj/YbgkuWT+/1Q2 Nn81KCTOj1dKh1JZcFvvXTaCLg6poj8KhukoFreiqjohxYSieEwEm49/DJAr9am1 TUoE4JNd5LtorQp2vnTZQAkvwz4fNT//ycphUAlI4JdQEoffuzN0N+57JJTNt0cw XEzJYCuS2j2lqRxnhDvARcoHhINH+32c7UkEfuT63FO0Wh4Ig1KM7vumLKh8uxM= =zWS3 -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--