From owner-freebsd-apache@FreeBSD.ORG Sat Mar 27 16:03:00 2010 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0D28106567B; Sat, 27 Mar 2010 16:03:00 +0000 (UTC) (envelope-from pgollucci@p6m7g8.com) Received: from exhub015-2.exch015.msoutlookonline.net (exhub015-2.exch015.msoutlookonline.net [207.5.72.94]) by mx1.freebsd.org (Postfix) with ESMTP id C8D7E8FC29; Sat, 27 Mar 2010 16:03:00 +0000 (UTC) Received: from [192.168.1.4] (96.245.192.86) by smtpx15.msoutlookonline.net (207.5.72.103) with Microsoft SMTP Server (TLS) id 8.2.234.1; Sat, 27 Mar 2010 09:03:00 -0700 Message-ID: <4BAE2C34.60202@p6m7g8.com> Date: Sat, 27 Mar 2010 12:03:00 -0400 From: "Philip M. Gollucci" Organization: P6 Web Applications User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.8) Gecko/20100227 Lightning/1.0b1 Thunderbird/3.0.3 MIME-Version: 1.0 To: Doug Barton References: <4BAD62C7.2050302@FreeBSD.org> In-Reply-To: <4BAD62C7.2050302@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: osa@freebsd.org, apache@freebsd.org Subject: Re: %%RC_SUBR%% code in apache and nginx X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2010 16:03:01 -0000 On 3/26/2010 9:43 PM, Doug Barton wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: RIPEMD160 > > Howdy, > > I am working on deprecating %%RC_SUBR%% and noticed the following: > > www/apache20/files/apache2.sh.in: > %%PREFIX%%/etc/rc.d/apache2%%RC_SUBR_SUFFIX%% $1 ${profile} > www/apache13-modssl/files/apache.in: > %%PREFIX%%/etc/rc.d/apache%%RC_SUBR_SUFFIX%% $1 ${profile} > www/nginx-devel/files/nginx.sh.in: > %%PREFIX%%/etc/rc.d/nginx%%RC_SUBR_SUFFIX%% $1 ${profile} > www/nginx/files/nginx.sh.in: > %%PREFIX%%/etc/rc.d/nginx%%RC_SUBR_SUFFIX%% $1 ${profile} > > I'm not 100% sure what the goals for that code are, but you might want > to review it with the goal of at minimum removing %%RC_SUBR%%. Also, the > value of RC_SUBR_SUFFIX is empty on all supported versions of FreeBSD, > and has been for some time. Anything you can do to simplify and/or > eliminate that code would be greatly appreciated. > Yes, I've previously removed it from www/apache22. I've been explicitly asked by portmgr@ to not make these changes though unless its bundled with other updates in the past. Go forth and change it! -- ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer, FreeBSD Foundation Sr. System Admin, Ridecharge Inc. Consultant, P6M7G8 Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.