From nobody Sun Apr 12 07:47:22 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ftjLt3Wrpz6YxXH; Sun, 12 Apr 2026 07:47:50 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4ftjLr6q5Tz45VL; Sun, 12 Apr 2026 07:47:48 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gojira.at header.s=fm2 header.b=K80iI725; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="W 947RFG"; dmarc=none; spf=pass (mx1.freebsd.org: domain of herbert@gojira.at designates 202.12.124.144 as permitted sender) smtp.mailfrom=herbert@gojira.at Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 13B001D001DB; Sun, 12 Apr 2026 03:47:47 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sun, 12 Apr 2026 03:47:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gojira.at; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1775980066; x=1776066466; bh=E6T5V49ERXnsdmzG+ajDuvMKG9O81P0Rp35VzcW1KI8=; b= K80iI725QMRWAiidOZTK8VKe36wrSyFX7qhpbWWee2JeYICd0vRSfs98Y1Hy3kLi CaGRzg+lDT8iBuS44DtmQ5WKpppbDeSJkKqLNLqinvTDD9I5q0nnG8Y9WkWzIv52 +i4FkJ7G9gavx9m6KP/oLgMwraEMqOGRh8VvjtX208bl7Mzem6CXO4SQgFFOnkwi LXkAZrbLrIWIIyZsEkFOJNh9oEjLcbHTPl1wFDP/8RcxyKb83b9OAtiNeEo3MImo dkXwK9qIWYy+xUwTFXL8xj53pAkFRvhI+s8AnlebIlehMk4thxqIdozKETJPA5CS V72POMHHWvyO9r32oGXkog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1775980066; x= 1776066466; bh=E6T5V49ERXnsdmzG+ajDuvMKG9O81P0Rp35VzcW1KI8=; b=W 947RFGEI+zFGvSNNeXnlRXKsTT8IIl/k/D5qoUUvztWfPbSTETUYrY5W0yaVNZS7 fYxDbZoSrP+3pisv0yuxa5LFAZKjbx7tMVWMRTsUeXznGQkluGL7EYfahIkGAVQW Y44XI2xX5PKl/C+hVqM4x38zMpYDJO9qD7Zkk8fSDkpQpTtIFqG3jza9BKVArZSd 52Vzbe0WrDw14Cd2nOD0Vy7HjA2yBdIdNIjWqKyMiegD5zN7YIVP9faApGgXKPgk T6sqe/mfWjSrEKBhuuUKsQyEBX87NWbk9kLLypoPSQE0xDoqz7NoHL6SRYN+d44I 0gr95u6zuQ6+gvvpka+Cw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdefgeejvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhepfffkhffvvefujghffgggtgfgsehtqhertd dtrehunecuhfhrohhmpedfjfgvrhgsvghrthculfdrucfukhhuhhhrrgdfuceohhgvrhgs vghrthesghhojhhirhgrrdgrtheqnecuggftrfgrthhtvghrnhepgfeifeduvdfhleejve duieeflefhgeeugfeijeekjeeuueffvdetieekgfduudelnecuffhomhgrihhnpehfrhgv vggsshgurdhorhhgpdhlihgsrdhmkhenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehhvghrsggvrhhtsehgohhjihhrrgdrrghtpdhnsggprhgt phhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjrhhttgdvjeesfh hrvggvsghsugdrohhrghdprhgtphhtthhopehnghhivgesfhhrvggvsghsugdrohhrghdp rhgtphhtthhopehsrhgtqdgtohhmmhhithhtvghrshesfhhrvggvsghsugdrohhrghdprh gtphhtthhopeguvghvqdgtohhmmhhithhsqdhsrhgtqdgrlhhlsehfrhgvvggsshgurdho rhhgpdhrtghpthhtohepuggvvhdqtghomhhmihhtshdqshhrtgdqmhgrihhnsehfrhgvvg gsshgurdhorhhg X-ME-Proxy: Feedback-ID: i64fe486c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Apr 2026 03:47:45 -0400 (EDT) Date: Sun, 12 Apr 2026 09:47:22 +0200 Message-ID: <87pl44y60l.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Jessica Clarke Cc: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 3797fe720a37 - main - libcrypto: compile all PIC objects with -DOPENSSL_PIC -fPIC In-Reply-To: References: <69bf4832.41a59.1df6e724@gitrepo.freebsd.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/31.0 Mule/6.0 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.59 / 15.00]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.993]; R_DKIM_ALLOW(-0.20)[gojira.at:s=fm2,messagingengine.com:s=fm2]; R_SPF_ALLOW(-0.20)[+ip4:202.12.124.128/27]; RCVD_IN_DNSWL_LOW(-0.10)[202.12.124.144:from]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; ASN(0.00)[asn:151847, ipnet:202.12.124.0/24, country:AU]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DWL_DNSWL_NONE(0.00)[messagingengine.com:dkim]; RCVD_VIA_SMTP_AUTH(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; RCVD_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[gojira.at]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gojira.at:+,messagingengine.com:+] X-Rspamd-Queue-Id: 4ftjLr6q5Tz45VL X-Spamd-Bar: -- On Mon, 23 Mar 2026 18:02:38 +0100, Jessica Clarke wrote: >=20 > On 22 Mar 2026, at 01:38, Enji Cooper wrote: > >=20 > > The branch main has been updated by ngie: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D3797fe720a37ff9fb5b20546= 494ef1c4a6c01541 > >=20 > > commit 3797fe720a37ff9fb5b20546494ef1c4a6c01541 > > Author: Enji Cooper > > AuthorDate: 2026-03-22 00:39:16 +0000 > > Commit: Enji Cooper > > CommitDate: 2026-03-22 01:38:49 +0000 > >=20 > > libcrypto: compile all PIC objects with -DOPENSSL_PIC -fPIC > >=20 > > This change modifies the libcrypto PIC objects to always compile with > > `-DOPENSSL_PIC -fPIC` to restore parity with the upstream build proc= ess. > > This ensures that the legacy provider is built with parity to the > > upstream legacy provider. > >=20 > > MFC after: 12 days > > Tested with: `make check` (legacy provider), `make univer= se` > > Fixes: 14b9955e > > Differential Revision: https://reviews.freebsd.org/D44896 > > --- > > secure/lib/libcrypto/Makefile | 6 ------ > > secure/lib/libcrypto/Makefile.inc | 3 +++ > > 2 files changed, 3 insertions(+), 6 deletions(-) > >=20 > > diff --git a/secure/lib/libcrypto/Makefile b/secure/lib/libcrypto/Makef= ile > > index 738de3479987..9d484e9d480c 100644 > > --- a/secure/lib/libcrypto/Makefile > > +++ b/secure/lib/libcrypto/Makefile > > @@ -687,12 +687,6 @@ SUBDIR.${MK_TESTS}=3D tests > >=20 > > .include > >=20 > > -.if ${MACHINE} =3D=3D "powerpc" > > -# Work around "relocation R_PPC_GOT16 out of range" errors > > -PICFLAG=3D -fPIC > > -.endif > > -PICFLAG+=3D -DOPENSSL_PIC > > - > > .if defined(ASM_${MACHINE_CPUARCH}) > > .PATH: ${SRCTOP}/sys/crypto/openssl/${MACHINE_CPUARCH} > > .if defined(ASM_amd64) > > diff --git a/secure/lib/libcrypto/Makefile.inc b/secure/lib/libcrypto/M= akefile.inc > > index 73c650d590ff..8f22d501e005 100644 > > --- a/secure/lib/libcrypto/Makefile.inc > > +++ b/secure/lib/libcrypto/Makefile.inc > > @@ -12,6 +12,9 @@ CFLAGS+=3D -I${LCRYPTO_SRC}/providers/common/include > > CFLAGS+=3D -I${LCRYPTO_SRC}/providers/fips/include > > CFLAGS+=3D -I${LCRYPTO_SRC}/providers/implementations/include > >=20 > > +PICFLAG=3D -fPIC > > +PICFLAG+=3D -DOPENSSL_PIC > > + > > .SUFFIXES: .pc > > .PATH.pc: ${LCRYPTO_SRC}/exporters >=20 > This isn=A2t what PICFLAG is for. Is there a reason you can=A2t use SHARE= D_CFLAGS? Is this the final fix and will it be merged to stable/15? Thanks.