Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Jun 2012 17:36:00 -0700
From:      Jack Vogel <jfvogel@gmail.com>
To:        Maksim Yevmenkin <emax@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r236729 - head/sys/dev/ixgbe
Message-ID:  <CAFOYbcnVH9wLc0N7Wj4qZaW2brz3h=coDbLSjGVh75A99=zCmw@mail.gmail.com>
In-Reply-To: <201206072257.q57MvQXI016696@svn.freebsd.org>
References:  <201206072257.q57MvQXI016696@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Just because the Linux driver does something does not mean that FreeBSD
should,
this may be OK, but it isn't something automatic, and with a thing like
this you should
at least have asked me first... please next time?

Jack


On Thu, Jun 7, 2012 at 3:57 PM, Maksim Yevmenkin <emax@freebsd.org> wrote:

> Author: emax
> Date: Thu Jun  7 22:57:26 2012
> New Revision: 236729
> URL: http://svn.freebsd.org/changeset/base/236729
>
> Log:
>  Correct typo(?) and actually set PTHRESH to 32 and not 16 as per Intel
>  Linux driver 3.8.21.
>
>  MFC after:    1 week
>
> Modified:
>  head/sys/dev/ixgbe/ixgbe.c
>
> Modified: head/sys/dev/ixgbe/ixgbe.c
>
> ==============================================================================
> --- head/sys/dev/ixgbe/ixgbe.c  Thu Jun  7 22:49:50 2012        (r236728)
> +++ head/sys/dev/ixgbe/ixgbe.c  Thu Jun  7 22:57:26 2012        (r236729)
> @@ -1152,7 +1152,7 @@ ixgbe_init_locked(struct adapter *adapte
>                 * from the Intel linux driver 3.8.21.
>                 * Prefetching enables tx line rate even with 1 queue.
>                 */
> -               txdctl |= (16 << 0) | (1 << 8);
> +               txdctl |= (32 << 0) | (1 << 8);
>                IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(i), txdctl);
>        }
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFOYbcnVH9wLc0N7Wj4qZaW2brz3h=coDbLSjGVh75A99=zCmw>