From owner-svn-src-all@FreeBSD.ORG Fri Jun 8 00:36:02 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A1391065670; Fri, 8 Jun 2012 00:36:02 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 77E068FC14; Fri, 8 Jun 2012 00:36:01 +0000 (UTC) Received: by vcbfy7 with SMTP id fy7so788197vcb.13 for ; Thu, 07 Jun 2012 17:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=F4uX558+Nj+OyP5jQqz9X0mnBrH0hCbM5tak4w8rqc0=; b=kP2LF9RTSn5Xi8vyKC7VGz5clSEiNzkpkJD/5bH5FPSn9HB2u7FWWknV/2xBULpcDa VgbEqG8/GeuD5Y8cUosevUL+LFcvO7Nw+p2+tCqgg3EMW+zLtmjPIiSdC2Hv2awy/iX6 a/eyrd3/Dy0q4Oo9JXkELJL2aFsjJVf+CfFNCvlfHHwLjTe0Xr3msT/KSXUuHvD7mnCm 5eWHxwllbI7RTXeqHbI7I6YsGdTVP5rQxP9xf7lYHtaD/Ickq8IPfuYLnYwZ3CI0/MVs 0gXWEftha89H/eYPQZxmySmq7ViAVWLExGLJZeuBddqE87ogazVmnz6nsdsemN/LZt+V Sn1w== MIME-Version: 1.0 Received: by 10.221.1.82 with SMTP id np18mr4227389vcb.22.1339115760797; Thu, 07 Jun 2012 17:36:00 -0700 (PDT) Received: by 10.220.236.201 with HTTP; Thu, 7 Jun 2012 17:36:00 -0700 (PDT) In-Reply-To: <201206072257.q57MvQXI016696@svn.freebsd.org> References: <201206072257.q57MvQXI016696@svn.freebsd.org> Date: Thu, 7 Jun 2012 17:36:00 -0700 Message-ID: From: Jack Vogel To: Maksim Yevmenkin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236729 - head/sys/dev/ixgbe X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2012 00:36:02 -0000 Just because the Linux driver does something does not mean that FreeBSD should, this may be OK, but it isn't something automatic, and with a thing like this you should at least have asked me first... please next time? Jack On Thu, Jun 7, 2012 at 3:57 PM, Maksim Yevmenkin wrote: > Author: emax > Date: Thu Jun 7 22:57:26 2012 > New Revision: 236729 > URL: http://svn.freebsd.org/changeset/base/236729 > > Log: > Correct typo(?) and actually set PTHRESH to 32 and not 16 as per Intel > Linux driver 3.8.21. > > MFC after: 1 week > > Modified: > head/sys/dev/ixgbe/ixgbe.c > > Modified: head/sys/dev/ixgbe/ixgbe.c > > ============================================================================== > --- head/sys/dev/ixgbe/ixgbe.c Thu Jun 7 22:49:50 2012 (r236728) > +++ head/sys/dev/ixgbe/ixgbe.c Thu Jun 7 22:57:26 2012 (r236729) > @@ -1152,7 +1152,7 @@ ixgbe_init_locked(struct adapter *adapte > * from the Intel linux driver 3.8.21. > * Prefetching enables tx line rate even with 1 queue. > */ > - txdctl |= (16 << 0) | (1 << 8); > + txdctl |= (32 << 0) | (1 << 8); > IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(i), txdctl); > } > >