From owner-svn-src-head@freebsd.org Fri Nov 20 14:58:47 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58964A3451D; Fri, 20 Nov 2015 14:58:47 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C7521E9B; Fri, 20 Nov 2015 14:58:47 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by ioir85 with SMTP id r85so125906246ioi.1; Fri, 20 Nov 2015 06:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=pMW2kXCBMFMX6LkgvNycVu8AMYBIYBheeOzIHW3vjLI=; b=vNnVzQn2qeTKmSKX6hV/cwPK9X2s09GAvG3PPD/2NleQ8M9fXogZ+eGp4sYWahJg0y C6fTsLKTovToy6tZrwQ1Se0vL7MsEqteA27X6OQFMbaDULWfhHeyn4Tn2sC4lNynJnu2 iqA0v9yVdO6kKu4vjEEz4S20EWc6pYORdLtMBEX67PCcjzocGtFXaF95HEBBiymiVNMv bdkwayS/gq/sPiFVDqYvZ9nVv315fj7qVRFaiwuFqhXKe+Nl9LMXvkKCJs8kQg5kIVzw CSV7zsnVxlqPRG2cMohK+LH8GCrnYr0BZEAAgKw1SzMImtmyTzqEV7+wA4yAZ6uOlaxp +i/w== X-Received: by 10.107.159.199 with SMTP id i190mr13281639ioe.29.1448031524988; Fri, 20 Nov 2015 06:58:44 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.169.85 with HTTP; Fri, 20 Nov 2015 06:58:25 -0800 (PST) In-Reply-To: <20151120141951.3c666ba5@bender> References: <201511181752.tAIHqcdF006755@repo.freebsd.org> <20151120141951.3c666ba5@bender> From: Ed Maste Date: Fri, 20 Nov 2015 09:58:25 -0500 X-Google-Sender-Auth: gmxFVsIir_BHZLZMnz1Fy3AhWXI Message-ID: Subject: Re: svn commit: r291021 - in head: sbin usr.sbin To: Andrew Turner Cc: Bryan Drewery , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2015 14:58:47 -0000 On 20 November 2015 at 09:19, Andrew Turner wrote: > On Wed, 18 Nov 2015 17:52:38 +0000 (UTC) > Bryan Drewery wrote: > >> Author: bdrewery >> Date: Wed Nov 18 17:52:38 2015 >> New Revision: 291021 >> URL: https://svnweb.freebsd.org/changeset/base/291021 >> >> Log: >> Convert to SUBDIR.yes format. >> >> Reviewed by: imp >> Sponsored by: EMC / Isilon Storage Division >> Differential Revision: https://reviews.freebsd.org/D4182 >> >> Modified: >> head/sbin/Makefile >> head/usr.sbin/Makefile > > This broke some mips. In usr.sbin/Makefile.mips we exclude uathload for > some variants of mips with "SUBDIR:= ${SUBDIR:Nuathload}", however this > is now no longer in SUBDIR. I also needed to disable uathload for my experimental builds using lld as the system linker. The :Nuathload feels a bit too magic to me; I'd welcome a change that makes disabling uathload more explicit.