From owner-freebsd-bugs@FreeBSD.ORG Fri Mar 26 11:40:06 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61617106566C for ; Fri, 26 Mar 2010 11:40:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 507288FC20 for ; Fri, 26 Mar 2010 11:40:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2QBe6bT014018 for ; Fri, 26 Mar 2010 11:40:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2QBe6CC014017; Fri, 26 Mar 2010 11:40:06 GMT (envelope-from gnats) Date: Fri, 26 Mar 2010 11:40:06 GMT Message-Id: <201003261140.o2QBe6CC014017@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Alexander Leidinger Cc: Subject: Re: kern/144584: [linprocfs][patch] bogus values in linprocfs X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Alexander Leidinger List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 11:40:06 -0000 The following reply was made to PR kern/144584; it has been noted by GNATS. From: Alexander Leidinger To: Petr Salinger Cc: bug-followup@FreeBSD.org Subject: Re: kern/144584: [linprocfs][patch] bogus values in linprocfs Date: Fri, 26 Mar 2010 12:29:58 +0100 Quoting Petr Salinger (from Fri, 26 Mar 2010 12:08:41 +0100 (CET)): >> mp_maxid needs to be proteced with "#ifdef SMP". > > Does not seem needed in 8.0, anyway, in non-SMP the > cnt (count of active processors) is clearly 1. I had a look at other places where it is used, and it is not protected in all places. So I let it like it is. >> The following gives an error in a 32bit compile, either cast i to >> long, or (probably better) change the type in the printf to int. > > change the type in the printf to int as i will be in range 0..99. Thanks for the confirmation. Bye, Alexander. -- "This may be sacrilege to you, but my client can do things for you that even Mr. Hoover might find out of his range." -- Tom Hagen, "Chapter 1", page 58 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137