From owner-freebsd-bugs@FreeBSD.ORG Fri Jan 27 12:40:11 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6924B1065676 for ; Fri, 27 Jan 2012 12:40:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 234BB8FC24 for ; Fri, 27 Jan 2012 12:40:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0RCeA9Q084153 for ; Fri, 27 Jan 2012 12:40:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0RCeAA5084152; Fri, 27 Jan 2012 12:40:10 GMT (envelope-from gnats) Resent-Date: Fri, 27 Jan 2012 12:40:10 GMT Resent-Message-Id: <201201271240.q0RCeAA5084152@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pierre Imai Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 97EF81065686 for ; Fri, 27 Jan 2012 12:30:59 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 831F58FC14 for ; Fri, 27 Jan 2012 12:30:59 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0RCUwjX095388 for ; Fri, 27 Jan 2012 12:30:58 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q0RCUwdl095387; Fri, 27 Jan 2012 12:30:58 GMT (envelope-from nobody) Message-Id: <201201271230.q0RCUwdl095387@red.freebsd.org> Date: Fri, 27 Jan 2012 12:30:58 GMT From: Pierre Imai To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/164538: [patch] add support for newer Lenovo ThinkPads to acpi_ibm X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2012 12:40:11 -0000 >Number: 164538 >Category: kern >Synopsis: [patch] add support for newer Lenovo ThinkPads to acpi_ibm >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Jan 27 12:40:10 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Pierre Imai >Release: 9.0-stable >Organization: >Environment: FreeBSD X.Y.net 9.0-STABLE FreeBSD 9.0-STABLE #0: Fri Jan 20 20:52:52 CET 2012 root@X.Y.net:/usr/obj/data/usr/src/sys/COMMON-AMD64 amd64 >Description: The acpi_ibm kernel module does not include the ID used by newer Lenovo Laptops (basically, "IBM0086" was replaced by "LEN0086"). Adding the new string to the ibm_ids struct in acpi_ibm.c allows the driver to attach and work properly. Tested during daily use on a ThinkPad W520 running 9.0-stable AMD64 since Nov 2011. >How-To-Repeat: Try "kldload ibm_acpi" on e.g. a Lenovo ThinkPad W520, the driver will not recognize the ACPI ID. >Fix: Replace line 293 of sys/dev/acpi_support/acpi_ibm.c: --- /usr/src/sys/dev/acpi_support/acpi_ibm.c.old 2012-01-27 13:18:19.000000000 +0100 +++ /usr/src/sys/dev/acpi_support/acpi_ibm.c 2012-01-27 13:19:32.000000000 +0100 @@ -290,7 +290,7 @@ DRIVER_MODULE(acpi_ibm, acpi, acpi_ibm_driver, acpi_ibm_devclass, 0, 0); MODULE_DEPEND(acpi_ibm, acpi, 1, 1, 1); -static char *ibm_ids[] = {"IBM0068", NULL}; +static char *ibm_ids[] = {"LEN0068", "IBM0068", NULL}; static void ibm_led(void *softc, int onoff) >Release-Note: >Audit-Trail: >Unformatted: