From owner-svn-src-head@freebsd.org Mon Aug 24 10:30:02 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F8C49BE97C for ; Mon, 24 Aug 2015 10:30:02 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 706239CC for ; Mon, 24 Aug 2015 10:30:01 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA14716; Mon, 24 Aug 2015 13:29:59 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1ZTp0p-000IfY-59; Mon, 24 Aug 2015 13:29:59 +0300 Subject: Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Fabian Keil References: <201507020832.t628W3WJ002944@repo.freebsd.org> <55BF6A84.1040808@FreeBSD.org> <25a69eb6.5dfe13af@fabiankeil.de> Cc: "svn-src-head@freebsd.org" From: Andriy Gapon Message-ID: <55DAF1EF.2080900@FreeBSD.org> Date: Mon, 24 Aug 2015 13:29:03 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <25a69eb6.5dfe13af@fabiankeil.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2015 10:30:02 -0000 On 03/08/2015 16:29, Fabian Keil wrote: > Andriy Gapon wrote: > >> On 30/07/2015 10:24, K. Macy wrote: >>> Just FYI this change introduces a deadlock with with the >>> spa_namespace_lock. Mount will be holding this lock while trying to >>> acquire the spa_namespace_lock. zfskern on the other hand holds the >>> spa_namespace_lock when calling zfs_freebsd_access which in turn >>> tries to acquire the teardown lock. >> >> I missed the fact that zpool.cache file is being written with spa_namespace_lock >> held. >> I'll try to either resolve the problem in the next day or I will revert the change. > > BTW, there's another (unrelated) spa_namespace_lock issue in spa_import_rootpool(): > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198563 Committed. Thank you! -- Andriy Gapon