From owner-freebsd-net@FreeBSD.ORG Sun Dec 15 06:40:24 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 15FB43EE; Sun, 15 Dec 2013 06:40:24 +0000 (UTC) Received: from mail-ob0-x22d.google.com (mail-ob0-x22d.google.com [IPv6:2607:f8b0:4003:c01::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C6CD21DDA; Sun, 15 Dec 2013 06:40:23 +0000 (UTC) Received: by mail-ob0-f173.google.com with SMTP id gq1so3614046obb.32 for ; Sat, 14 Dec 2013 22:40:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3gdBQEsRrmSiEF4ls81Jpc1bNySSkAZB7VHPLS/dvUQ=; b=Gq0AeF9HANoE7NWwzziQ0LyuUiM9qSp+qroT23T+R+noNWLA6Htc0kOWKsRRrTV2or fOyv3kqWJqNcjctixIi2rXFrKc0nEhjqIaPtCrF71gznYL81N+X9O7FSdjFWHoE2qcxe iKDRyxscCIgaHMKa5DhzcV92mqSYW+T68lHsebxGFnerUgCs5lbaixXoL2MzA/AWtqI4 KJ7TBHgg0dZuNf7HuvRMSlr3t9L4bLAYn8G/XUIROEpmhKj6OmoNC4byidup8EqgEbE2 39E70RR4Tijc2vKiuXYsfgy8QJl3ZvtBf0AaHM+Lj8g/V4Y3lfjIw52WmYtYPIlCPYPP DkDw== MIME-Version: 1.0 X-Received: by 10.182.24.69 with SMTP id s5mr7432255obf.35.1387089622480; Sat, 14 Dec 2013 22:40:22 -0800 (PST) Received: by 10.76.158.225 with HTTP; Sat, 14 Dec 2013 22:40:22 -0800 (PST) In-Reply-To: References: Date: Sun, 15 Dec 2013 01:40:22 -0500 Message-ID: Subject: Re: buf_ring in HEAD is racy From: Ryan Stone To: Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Dec 2013 06:40:24 -0000 On Sat, Dec 14, 2013 at 7:06 PM, Adrian Chadd wrote: > oh cool, you just did the output-drops thing I was about to code up. > We're missing those counters at work and the ops guys poked me about > it. > > I'll also give that a whirl locally and see about working with jack to > get it into -HEAD / MFC'ed to 10. > > Thanks! The reason why I call it hacky is because these drops are properly categorized as discards, not errors. But there's not currently a really good way to distinguish between the two in FreeBSD right now (there is the drops counter in the if_snd queue but netstat seemed to be ignoring that even with -d specified and blindly overwriting it would seem to be incompatible with altq anyway)