Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Nov 2012 19:28:20 -0500
From:      Eitan Adler <eadler@freebsd.org>
To:        Bryan Drewery <bdrewery@freebsd.org>
Cc:        svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r307920 - head/Mk
Message-ID:  <CAF6rxg=jq4kWg2D3x93uH3jNf5vVVrNBqrkoNVEfCJ%2B4fKxGSg@mail.gmail.com>
In-Reply-To: <50B69FB2.3070100@FreeBSD.org>
References:  <201211281724.qASHOrKc095304@svn.freebsd.org> <CAF6rxgkbrxN7OhWSHif81uXF4TdecvjVUWuxoQtkkJhtOC23wA@mail.gmail.com> <50B69F6F.5080206@FreeBSD.org> <50B69FB2.3070100@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 28 November 2012 18:35, Bryan Drewery <bdrewery@freebsd.org> wrote:
> On 11/28/2012 5:34 PM, Bryan Drewery wrote:
>> On 11/28/2012 11:30 AM, Eitan Adler wrote:
>>> On 28 November 2012 12:24, Baptiste Daroussin <bapt@freebsd.org> wrote:
>>>> Author: bapt
>>>> Date: Wed Nov 28 17:24:53 2012
>>>> New Revision: 307920
>>>> URL: http://svnweb.freebsd.org/changeset/ports/307920
>>>>
>>>> Log:
>>>>   Removed pygtk from bsd.gnome.mk
>>>>
>>>>   Approved by:  gnome (kwm)
>>>>   Feature safe: yes
>>>
>>> Can you please update the portmgr implementation page?  Clearly the
>>> documented version of "Feature Safe" is wrong.  We shouldn't have
>>> undocumented rules which supersede documented ones.
>>>
>>
>>     Here is an incomplete list. If you are unsure that your proposed
>>     change falls into this categorization, you must ask portmgr before
>>     committing.
>>
>> For me, the keywords are "unsure" and "must ask portmgr", not "This list
>> of items are disallowed always."
>>
> Well the intent of that is to clarify what is allowed, but the key
> purpose of the whole policy is to avoid rebuilding packages or holding
> up building packages due to major breakabe. Don't forget that.

I know. I'm not saying this commit wasn't feature safe. I'm saying the
policy is worded badly - but its obvious bapt doesn't agree so I'll
stop arguing this point now.


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=jq4kWg2D3x93uH3jNf5vVVrNBqrkoNVEfCJ%2B4fKxGSg>