From owner-svn-ports-all@FreeBSD.ORG Thu Nov 29 00:28:52 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 748A6144 for ; Thu, 29 Nov 2012 00:28:52 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id D950D8FC12 for ; Thu, 29 Nov 2012 00:28:51 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so11090938lbb.13 for ; Wed, 28 Nov 2012 16:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=2VlykQCjwKHeoRN0qhUYwD0lrcMNxMn/WHYZ5corZDo=; b=EIXy/lCZGfZKctofjFP9WhdI2Tl0IT0+q7suOGs43zTqDgJ9o2uiYWgKqqNpYckovR PRNsKFwAg99jwsRFl8c6T2rEKu3NNm+T0XYpmw3WCVeJyEAuwXt4xnxWeXyOYLLv3YCG zr3KwuVe1MkY8jQFfft7iZbDQEp/1hd3do70g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=2VlykQCjwKHeoRN0qhUYwD0lrcMNxMn/WHYZ5corZDo=; b=H8rp2tK3snZcW39lvCtnqfrHJMsJ8QAoh/QGLt6KXA0UN7QH+reGt5yefZtmw1dORy NGjhcNzzHitkc7nRHPGNaZqgsvdmiTIUd4Rrd4o3w5fJ0SeDLara2KXSc1YEi5bThCDn uklvdJgFk2aMh9+Co09D/KDUJiRw5wi4K1CnlnR66XC4FP/rWeARoVmx4uG+xGavchNq Wcae+kExbTtdUVK9FSBolwkv2kBZSBoJBawgO608TEDi1QYTnoUknau7upDXo4GYrF4K HSal/1utv4UJ5yHF6gP1dKZLsowgQ9mA2hX1nv4J8a/olDISC8Lay9bJzK/6hFrYH9VD JkQg== Received: by 10.112.103.135 with SMTP id fw7mr4070613lbb.17.1354148930588; Wed, 28 Nov 2012 16:28:50 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Wed, 28 Nov 2012 16:28:20 -0800 (PST) In-Reply-To: <50B69FB2.3070100@FreeBSD.org> References: <201211281724.qASHOrKc095304@svn.freebsd.org> <50B69F6F.5080206@FreeBSD.org> <50B69FB2.3070100@FreeBSD.org> From: Eitan Adler Date: Wed, 28 Nov 2012 19:28:20 -0500 X-Google-Sender-Auth: QhtFk2FFIkDmyFpOhzrbZoUg5OA Message-ID: Subject: Re: svn commit: r307920 - head/Mk To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkfrkLTyIXrrxua2ycSDvi6onOuyxhieCto3tKjKh236f6rAMNreLOyt676qeDdVTh4qgny Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2012 00:28:52 -0000 On 28 November 2012 18:35, Bryan Drewery wrote: > On 11/28/2012 5:34 PM, Bryan Drewery wrote: >> On 11/28/2012 11:30 AM, Eitan Adler wrote: >>> On 28 November 2012 12:24, Baptiste Daroussin wrote: >>>> Author: bapt >>>> Date: Wed Nov 28 17:24:53 2012 >>>> New Revision: 307920 >>>> URL: http://svnweb.freebsd.org/changeset/ports/307920 >>>> >>>> Log: >>>> Removed pygtk from bsd.gnome.mk >>>> >>>> Approved by: gnome (kwm) >>>> Feature safe: yes >>> >>> Can you please update the portmgr implementation page? Clearly the >>> documented version of "Feature Safe" is wrong. We shouldn't have >>> undocumented rules which supersede documented ones. >>> >> >> Here is an incomplete list. If you are unsure that your proposed >> change falls into this categorization, you must ask portmgr before >> committing. >> >> For me, the keywords are "unsure" and "must ask portmgr", not "This list >> of items are disallowed always." >> > Well the intent of that is to clarify what is allowed, but the key > purpose of the whole policy is to avoid rebuilding packages or holding > up building packages due to major breakabe. Don't forget that. I know. I'm not saying this commit wasn't feature safe. I'm saying the policy is worded badly - but its obvious bapt doesn't agree so I'll stop arguing this point now. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams