From owner-cvs-all  Thu Nov 28 12:39: 7 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E3BDB37B401; Thu, 28 Nov 2002 12:39:06 -0800 (PST)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7C07043EBE; Thu, 28 Nov 2002 12:39:06 -0800 (PST)
	(envelope-from rizzo@xorpc.icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.3/8.12.3) with ESMTP id gASKd0TO075125;
	Thu, 28 Nov 2002 12:39:01 -0800 (PST)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.3/8.12.3/Submit) id gASKd0Bw075096;
	Thu, 28 Nov 2002 12:39:00 -0800 (PST)
	(envelope-from rizzo)
Date: Thu, 28 Nov 2002 12:38:58 -0800
From: Luigi Rizzo <luigi@FreeBSD.org>
To: "Vladimir B.  Grebenschikov" <vova@sw.ru>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/ipfw ipfw2.c
Message-ID: <20021128123857.A70108@xorpc.icir.org>
References: <200211261958.gAQJwCal000509@repoman.freebsd.org> <1038477062.764.83.camel@vbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <1038477062.764.83.camel@vbook>; from vova@sw.ru on Thu, Nov 28, 2002 at 12:51:03PM +0300
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Nov 28, 2002 at 12:51:03PM +0300, Vladimir B.  Grebenschikov wrote:
...
> So, one can abuse kernel by invalid ipfw instruction sequence, may be
> kernel should check this while add rule ?

yes the kernel it should check, i will try to add the (trivial)
check code soon.
On the other hand this can only happen as root, and there is
a simpler way to panic a system:

	cat /dev/zero > /dev/mem

so i guess this is not more dangerous.

	cheers
	luigi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message