From owner-freebsd-usb@FreeBSD.ORG  Thu Jul 17 12:19:17 2008
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 544F11065683
	for <freebsd-usb@freebsd.org>; Thu, 17 Jul 2008 12:19:17 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe05.swip.net [212.247.154.129])
	by mx1.freebsd.org (Postfix) with ESMTP id B60688FC16
	for <freebsd-usb@freebsd.org>; Thu, 17 Jul 2008 12:19:16 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=ThTHBw9avVQrSAajcP8A:9
	a=Vn91_RZ6VKR9sza_sTaxyroGWaoA:4 a=50e4U0PicR4A:10
Received: from [193.217.167.134] (account mc467741@c2i.net HELO [10.0.0.249])
	by mailfe05.swip.net (CommuniGate Pro SMTP 5.2.4b)
	with ESMTPA id 909259528; Thu, 17 Jul 2008 14:19:14 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-usb@freebsd.org
Date: Thu, 17 Jul 2008 14:20:51 +0200
User-Agent: KMail/1.9.7
References: <0707E37B6D2E244C85660487B602C92217ABC04434@ex02.briontech.com>
In-Reply-To: <0707E37B6D2E244C85660487B602C92217ABC04434@ex02.briontech.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200807171420.52900.hselasky@c2i.net>
Cc: Luoqi Chen <Luoqi.Chen@brion.com>
Subject: Re: Maintainer of usb code
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jul 2008 12:19:17 -0000

Hi Luoqi,

=46rom what version of FreeBSD did you fetch your ohci.c ?

=2D-HPS

On Thursday 17 July 2008, Luoqi Chen wrote:
> Hello,
>
> Do we have an official maintainer of the usb code? I came across some qui=
te
> trivial errors while debugging another problem (which turned out not to be
> usb related), please see the diff below. I'm not terribly familiar with t=
he
> usb code, so I'd like to seek someone to review this change,
>
> Index: ohci.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/src/sys/dev/usb/ohci.c,v
> retrieving revision 1.170
> diff -u -r1.170 ohci.c
> --- ohci.c      20 Jun 2007 05:10:52 -0000      1.170
> +++ ohci.c      17 Jul 2008 10:07:07 -0000
> @@ -815,20 +815,19 @@
>  ohci_controller_init(ohci_softc_t *sc)
>  {
>         int i;
> -       u_int32_t s, ctl, ival, hcr, fm, per, desca;
> +       u_int32_t ctl, ival, hcr, fm, per, desca;
>
>         /* Determine in what context we are running. */
>         ctl =3D OREAD4(sc, OHCI_CONTROL);
>         if (ctl & OHCI_IR) {
>                 /* SMM active, request change */
>                 DPRINTF(("ohci_init: SMM active, request owner change\n")=
);
> -               s =3D OREAD4(sc, OHCI_COMMAND_STATUS);
> -               OWRITE4(sc, OHCI_COMMAND_STATUS, s | OHCI_OCR);
> +               OWRITE4(sc, OHCI_COMMAND_STATUS, OHCI_OCR);
>                 for (i =3D 0; i < 100 && (ctl & OHCI_IR); i++) {
>                         usb_delay_ms(&sc->sc_bus, 1);
>                         ctl =3D OREAD4(sc, OHCI_CONTROL);
>                 }
> -               if ((ctl & OHCI_IR) =3D=3D 0) {
> +               if (ctl & OHCI_IR) {
>                         printf("%s: SMM does not respond, resetting\n",
>                                device_get_nameunit(sc->sc_bus.bdev));
>                         OWRITE4(sc, OHCI_CONTROL, OHCI_HCFS_RESET);
>
> Thanks
> -lq