From owner-freebsd-current@freebsd.org  Mon Dec 19 18:40:05 2016
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D63EAC883C0
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Mon, 19 Dec 2016 18:40:05 +0000 (UTC)
 (envelope-from kargl@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "troutmask", Issuer "troutmask" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id B87661FC1;
 Mon, 19 Dec 2016 18:40:05 +0000 (UTC)
 (envelope-from kargl@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])
 by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id uBJIdx7M001076
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 19 Dec 2016 10:39:59 -0800 (PST)
 (envelope-from kargl@troutmask.apl.washington.edu)
Received: (from kargl@localhost)
 by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id uBJIdwF6001075;
 Mon, 19 Dec 2016 10:39:58 -0800 (PST) (envelope-from kargl)
Date: Mon, 19 Dec 2016 10:39:58 -0800
From: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
To: John Baldwin <jhb@freebsd.org>
Cc: Mark Johnston <markj@freebsd.org>, kargl@uw.edu,
 freebsd-current@freebsd.org, kib@freebsd.org
Subject: Re: Revision 309657 to stack_machdep.c renders unbootable system
Message-ID: <20161219183958.GA876@troutmask.apl.washington.edu>
Reply-To: kargl@uw.edu
References: <20161214194848.GA881@troutmask.apl.washington.edu>
 <20161214234804.GA26443@troutmask.apl.washington.edu>
 <20161215005012.GA84222@wkstn-mjohnston.west.isilon.com>
 <1848178.kLUBJlL36D@ralph.baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1848178.kLUBJlL36D@ralph.baldwin.cx>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Mailman-Approved-At: Mon, 19 Dec 2016 18:58:43 +0000
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Dec 2016 18:40:05 -0000

On Fri, Dec 16, 2016 at 03:19:09PM -0800, John Baldwin wrote:
> 
> So the hack in pause() is probably not as necessary now.  In particular, I
> think we only need it for thread0, not for other threads.  The patch below
> worked for me with SPEW's config:
> 
> Index: kern_synch.c
> ===================================================================
> --- kern_synch.c	(revision 310128)
> +++ kern_synch.c	(working copy)
> @@ -321,7 +321,8 @@ pause_sbt(const char *wmesg, sbintime_t sbt, sbint
>  	if (sbt == 0)
>  		sbt = tick_sbt;
>  
> -	if (cold || kdb_active || SCHEDULER_STOPPED()) {
> +	if ((cold && curthread == &thread0) || kdb_active ||
> +	    SCHEDULER_STOPPED()) {
>  		/*
>  		 * We delay one second at a time to avoid overflowing the
>  		 * system specific DELAY() function(s):
> 
> 

John, 

The above patch fixes the boot issue for me.  Thanks for the
quick response.

-- 
Steve
http://troutmask.apl.washington.edu/~kargl/
 2. https://www.youtube.com/watch?v=Py6d6o2jbaE
 1. https://www.youtube.com/watch?v=6hwgPfCcpyQ