Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Jun 2012 21:39:00 +0000 (UTC)
From:      Attilio Rao <attilio@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r237172 - head/sys/vm
Message-ID:  <201206162139.q5GLd0Ck067245@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: attilio
Date: Sat Jun 16 21:39:00 2012
New Revision: 237172
URL: http://svn.freebsd.org/changeset/base/237172

Log:
  Do a more targeted check on the page cache and avoid to check the cache
  pointer directly in vnode_pager_setsize() by using newly introduced
  vm_page_is_cached() function.
  
  Reviewed by:	alc
  MFC after:	2 weeks
  X-MFC:		r234039,234064

Modified:
  head/sys/vm/vnode_pager.c

Modified: head/sys/vm/vnode_pager.c
==============================================================================
--- head/sys/vm/vnode_pager.c	Sat Jun 16 21:37:15 2012	(r237171)
+++ head/sys/vm/vnode_pager.c	Sat Jun 16 21:39:00 2012	(r237172)
@@ -440,7 +440,7 @@ vnode_pager_setsize(vp, nsize)
 			 */
 			vm_page_clear_dirty(m, base, PAGE_SIZE - base);
 		} else if ((nsize & PAGE_MASK) &&
-		    __predict_false(object->cache != NULL)) {
+		    vm_page_is_cached(object, OFF_TO_IDX(nsize))) {
 			vm_page_cache_free(object, OFF_TO_IDX(nsize),
 			    nobjsize);
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206162139.q5GLd0Ck067245>