Date: Sat, 07 May 2022 07:23:59 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: vishwin@freebsd.org Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 097c9235d921 - main - security/xmlsec1: update to 1.2.34,Re: git: 097c9235d921 - main - security/xmlsec1: update to 1.2.34 Message-ID: <20220507.072359.1120576587339561081.hrs@FreeBSD.org> In-Reply-To: <352dc9f0-713b-2c40-52fb-e7114af23c21@freebsd.org> References: <202205061736.246Haoqo000396@gitrepo.freebsd.org> <202205061736.246Haoqo000396@gitrepo.freebsd.org> <352dc9f0-713b-2c40-52fb-e7114af23c21@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Sat_May__7_07_23_59_2022_159)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Charlie Li <vishwin@freebsd.org> wrote
in <352dc9f0-713b-2c40-52fb-e7114af23c21@freebsd.org>,<352dc9f0-713b-2c40-52fb-e7114af23c21@freebsd.org>:
vi> Hiroki Sato wrote:
vi> > diff --git a/security/xmlsec1/Makefile b/security/xmlsec1/Makefile
vi> > index 6a1359ffb91e..6d6ccfa6822c 100644
vi> > --- a/security/xmlsec1/Makefile
vi> > +++ b/security/xmlsec1/Makefile
vi> > @@ -25,6 +24,7 @@ USE_LDCONFIG= yes
vi> > GNU_CONFIGURE= yes
vi> > CONFIGURE_ARGS= --with-openssl="${OPENSSLBASE}" \
vi> > --with-gcrypt="${LOCALBASE}" \
vi> > + --enable-werror \
vi> Why? This single-handedly caused PR 263826, though it did expose
vi> missing symbols on the LibreSSL side of things.
To detect potential problems. Any concerns by enabling -Werror?
vi> > *****************************************************************************/
vi> This patch hasn't been needed for a while now. Everything in here had
vi> already been upstreamed, partially by myself.
Thank you. I overlooked it was not necessary as you pointed out. I
will remove it.
-- Hiroki
----Security_Multipart(Sat_May__7_07_23_59_2022_159)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iMkEABMKAC4WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCYnWf/xAcaHJzQGZyZWVi
c2Qub3JnAAoJENuwfcZvH3N/fCoCB1vFzQsZlMGO089DweFxJ8QDeEMKNiDjITIb
LSDetJlrZqkkERQeXCyPtc8gLEdy7YwXcEw4D3h7T4um/+mVr5ZjAgkBwKew9OIX
iFAsIdk4IJHpa8xPeoaY4vzwmjX5cVzjkIT3FsJznVVW3AkSho5l3q3dXND4m+Y2
yGEVh11abmUjYPw=
=7FXL
-----END PGP SIGNATURE-----
----Security_Multipart(Sat_May__7_07_23_59_2022_159)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220507.072359.1120576587339561081.hrs>