From owner-svn-src-all@freebsd.org Tue Aug 21 21:24:42 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20847107F78C; Tue, 21 Aug 2018 21:24:42 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [198.45.61.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 779D89678F; Tue, 21 Aug 2018 21:20:49 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id w7LLKlU3054985 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Aug 2018 14:20:47 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id w7LLKlM8054984; Tue, 21 Aug 2018 14:20:47 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Tue, 21 Aug 2018 14:20:47 -0700 From: Gleb Smirnoff To: Matt Macy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337866 - in head/sys: net netinet netinet6 Message-ID: <20180821212047.GM27633@FreeBSD.org> References: <201808152023.w7FKN9LL055254@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201808152023.w7FKN9LL055254@repo.freebsd.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 21:24:42 -0000 On Wed, Aug 15, 2018 at 08:23:09PM +0000, Matt Macy wrote: M> @@ -3772,8 +3775,11 @@ if_delmulti_locked(struct ifnet *ifp, struct ifmultiad M> ll_ifma->ifma_ifp = NULL; /* XXX */ M> if (--ll_ifma->ifma_refcount == 0) { M> if (ifp != NULL) { M> - CK_STAILQ_REMOVE(&ifp->if_multiaddrs, ll_ifma, ifmultiaddr, M> - ifma_link); M> + if (ll_ifma->ifma_flags & IFMA_F_ENQUEUED) { M> + CK_STAILQ_REMOVE(&ifp->if_multiaddrs, ll_ifma, ifmultiaddr, M> + ifma_link); M> + ifma->ifma_flags &= ~IFMA_F_ENQUEUED; M> + } M> } M> if_freemulti(ll_ifma); M> } Coverity suggested there is a cut and paste mistake here, and it is compilable. After quick glance I tend to agree. Looks like flag is cleared on wrong ifma. -- Gleb Smirnoff