From owner-svn-src-all@freebsd.org Wed Jun 17 02:33:15 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 850CA33F6B5 for ; Wed, 17 Jun 2020 02:33:15 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2k.ore.mailhop.org (outbound2k.ore.mailhop.org [54.148.219.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49mpyf6Zp0z4867 for ; Wed, 17 Jun 2020 02:33:14 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1592361193; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=cENQ5UkAH+EgeXyUuGNppWdKiJnG+7/7bxi6JWAza4UKzINAtw0ofyqlmonM6UL5maYikoJ1O7gx0 VUVW/oylLSLQ0Q9ypq3vtKDwHiOP41FlU6U3hvmn1YFjNKP2g477taL/HwVm+6nmuwA3SdqG45QyYQ LK8QI9OlXyWa2aLyUeB4B54YBrR7n/X4701KSq4OpLosougaNNS93Uu5ul6mmz/EzrZTYcDwkLvGcr CwXx1ZQKtky0ooKJgGe7Bq7LPJ7pvj3SW29VviAT8Rdg50jJ3Wzxku07xgngSHaUd3hbiP5bx0Ox+i o0Qz0zybvxrHJq2NLxHDr7zfmDlbvCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=EgKyVA8g/wjRjCXO+zei1uWV6cKm9YVudzyNbQBjryI=; b=GrALHqOW1ZmWTFyxKCuUF/Exj+wF1HrExVQYZfhkEGCqTxLcr9YWPFlyEP1x8UYYsnIAzlD5ibVRf S/wBQYtivplXeHIdugF9cJSgvMYYpOahKhmuCH2qkVKHvcvyyPJgy35upLjMAEaivpntUk4uKO7BmS uFDq5aBelPrjyHELvJU4Qr6t2Jc38ZzGG+6EwrqTbx9432QjEDH+zbCo8HbFGIqjLb0erRYPxUM6k7 GzHEr9SLU4uQXRZ+A5q+9n3H75cmy7albrsyfggcRZ3YP0ja978M7mBJjkAWNIkMMyvEsoOXPl7XFN /lsZFkqqBTWr4aSti2Po3d9Nr7f7ECw== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=EgKyVA8g/wjRjCXO+zei1uWV6cKm9YVudzyNbQBjryI=; b=EXkvis60u29R46P569aMgqdpZMy+uigYMKiC4nHQFUGRQ7coiwD8Xe1vFGmgV8e38d7ioQSBsAcCC qd2tYZw5icKEze9bQgcnzUMA4Lo8S0Q3L04t8vapU+LorYcr75PFcO9/F8Gjj5Fe8awcwsLFjuK+MT ht0DDtjLn2Q+hjB5+WwwxH11QkOzYva3hWyfnFBalD+h+/MpgHBFIrPKKi1LsY44zuWL++RsVFxniK /RCpv9Q1mBIsMJ36eeczgGd1SR+PHggFmTmALqAVTp9L0d78yYFjvkjbij0saHzfpE0g8C6Os68ezu /zjUDIm6BTQSUCluqL82HvyT3xTIP+Q== X-MHO-RoutePath: aGlwcGll X-MHO-User: e307363d-b042-11ea-a067-6d02e42e573a X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id e307363d-b042-11ea-a067-6d02e42e573a; Wed, 17 Jun 2020 02:33:12 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 05H2XALm027670; Tue, 16 Jun 2020 20:33:10 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <8948411d5bb0ab7ffae4c9cba06bda7b8943e0cd.camel@freebsd.org> Subject: Re: svn commit: r362217 - head/stand/common From: Ian Lepore To: Kristof Provost , Ed Maste Cc: Toomas Soome , src-committers , svn-src-all , svn-src-head Date: Tue, 16 Jun 2020 20:33:10 -0600 In-Reply-To: References: <202006160705.05G753T4057972@repo.freebsd.org> <55903c38d363aef2a6f6d0075dd4526b86d51258.camel@freebsd.org> Content-Type: text/plain; charset="iso-8859-7" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 49mpyf6Zp0z4867 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 02:33:15 -0000 On Tue, 2020-06-16 at 19:34 +0200, Kristof Provost wrote: > On 16 Jun 2020, at 19:11, Ed Maste wrote: > > On Tue, 16 Jun 2020 at 13:01, Ian Lepore wrote: > > > > > > As much as I prefer doing it this way, style(9) doesn't allow for > > > variable declarations inside a for() statement (or even inside a > > > local > > > block, which is just too 1980s for me, but it is still our standard). > > > > Perhaps it's time to update style(9) to at least permit these uses, as > > we've done with the blank line at the beginning of functions with no > > local variables, and with braces around single-line bodies. > > We have 431 instances of `for (int i` in sys alone. It¢s not so much a > question of allowing it as acknowledging reality at this point. > > Best regards, > Kristof Hmm, so we do. If you weed out sys/contrib, and device drivers contributed by vendors, the number is a lot smaller, but still big enough that we should just change the rules I think. -- Ian