From owner-svn-src-head@FreeBSD.ORG Mon Jul 6 12:58:32 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF8EB1065670; Mon, 6 Jul 2009 12:58:32 +0000 (UTC) (envelope-from rink@rink.nu) Received: from mx1.rink.nu (gloom.rink.nu [213.34.49.2]) by mx1.freebsd.org (Postfix) with ESMTP id 9EB198FC12; Mon, 6 Jul 2009 12:58:32 +0000 (UTC) (envelope-from rink@rink.nu) Received: from localhost (localhost [127.0.0.1]) by mx1.rink.nu (Postfix) with ESMTP id 4D6B86D42B; Mon, 6 Jul 2009 14:39:59 +0200 (CEST) X-Virus-Scanned: amavisd-new at rink.nu Received: from mx1.rink.nu ([213.34.49.2]) by localhost (gloom.rink.nu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v2cUY-rKB7Rk; Mon, 6 Jul 2009 14:39:57 +0200 (CEST) Received: by mx1.rink.nu (Postfix, from userid 1000) id B1F616D423; Mon, 6 Jul 2009 14:39:57 +0200 (CEST) Date: Mon, 6 Jul 2009 14:39:57 +0200 From: Rink Springer To: Attilio Rao Message-ID: <20090706123957.GA76863@rink.nu> References: <200907060931.n669V4Zc074488@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907060931.n669V4Zc074488@svn.freebsd.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195403 - head/lib/libthr/thread X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2009 12:58:33 -0000 On Mon, Jul 06, 2009 at 09:31:04AM +0000, Attilio Rao wrote: > Log: > In the current code, rdlock_count is not correctly handled for some cases. > The most notable is that it is not bumped in rwlock_rdlock_common() when > the hard path (__thr_rwlock_rdlock()) returns successfully. > This can lead to deadlocks in libthr when rwlocks recursion in read mode > happens. > Fix the interested parts by correctly handling rdlock_count. > > PR: threads/136345 > Reported by: rink > Tested by: rink > Reviewed by: jeff > Approved by: re (kib) > MFC: 2 weeks Thanks! -- Rink P.W. Springer - http://rink.nu "Doom, gloom and despair. I like it!" - Tiresias