From owner-svn-src-projects@FreeBSD.ORG Tue Jan 4 22:50:28 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD298106564A; Tue, 4 Jan 2011 22:50:28 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id BCAF68FC1F; Tue, 4 Jan 2011 22:50:28 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p04MoS2N057451; Tue, 4 Jan 2011 22:50:28 GMT (envelope-from imp@svn.freebsd.org) Received: (from imp@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p04MoSDi057449; Tue, 4 Jan 2011 22:50:28 GMT (envelope-from imp@svn.freebsd.org) Message-Id: <201101042250.p04MoSDi057449@svn.freebsd.org> From: Warner Losh Date: Tue, 4 Jan 2011 22:50:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r216981 - projects/graid/head/sys/geom/raid X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2011 22:50:28 -0000 Author: imp Date: Tue Jan 4 22:50:28 2011 New Revision: 216981 URL: http://svn.freebsd.org/changeset/base/216981 Log: Use only 24 bytes to accomidate the SATA label. Intel doesn't do SAS drives for this kind of raid, so no need to waste stack in case we see a SAS drive with the intel metadata on it. Reviewed by: mav@ Modified: projects/graid/head/sys/geom/raid/md_intel.c Modified: projects/graid/head/sys/geom/raid/md_intel.c ============================================================================== --- projects/graid/head/sys/geom/raid/md_intel.c Tue Jan 4 22:47:42 2011 (r216980) +++ projects/graid/head/sys/geom/raid/md_intel.c Tue Jan 4 22:50:28 2011 (r216981) @@ -608,14 +608,14 @@ g_raid_md_create_intel(struct g_raid_md_ * ataraid(7) code always uses the last 16 characters of the label to * store into the Intel meta format. Generalize this to N characters * since that's easy. Labels can be up to 20 characters for SATA drives - * and up 251 characters for SAS drives. Allocate a little extra to be - * safe. + * and up 251 characters for SAS drives. Since intel controllers don't + * support SAS drives, just stick with the SATA limits for stack friendliness. */ static int g_raid_md_get_label(struct g_consumer *cp, char *serial, int serlen) { - char serial_buffer[256]; + char serial_buffer[24]; int len, error; len = sizeof(serial_buffer);