From owner-svn-src-head@freebsd.org Fri May 15 20:12:27 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BC3DB2FFA5A; Fri, 15 May 2020 20:12:27 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49P0234cjbz4PqB; Fri, 15 May 2020 20:12:27 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Received: from Ryans-MBP.attlocal.net (unknown [IPv6:2600:1700:358a:c660:904d:8f18:1bde:14ec]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: freqlabs/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 561C61DFF2; Fri, 15 May 2020 20:12:27 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Subject: Re: svn commit: r361066 - head/usr.sbin/jail To: rgrimes@freebsd.org, Ryan Moeller Cc: Mateusz Piotrowski <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202005151924.04FJOoQM087849@gndrsh.dnsmgr.net> From: Ryan Moeller Message-ID: Date: Fri, 15 May 2020 16:12:26 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <202005151924.04FJOoQM087849@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 20:12:27 -0000 On 5/15/20 3:24 PM, Rodney W. Grimes wrote: >> On 5/15/20 6:18 AM, Mateusz Piotrowski wrote: >> >>> On 5/15/20 1:38 AM, Ryan Moeller wrote: >>>> Author: freqlabs >>>> Date: Thu May 14 23:38:11 2020 >>>> New Revision: 361066 >>>> URL: https://svnweb.freebsd.org/changeset/base/361066 >>>> >>>> Log: >>>> jail: Add exec.prepare and exec.release command hooks >>>> >>>> This change introduces new jail command hooks that run before and after any >>>> other actions. >>> Should it go into RELNOTES? >> I'm not sure what all the criteria are for relnotes. >> The committer's guide makes it seem like relnotes is for breaking >> changes, which this is not. > Please could you point at which specific language in the commiters > guide makes you believe that the RELNOTES are for breaking changes? Every mention of "release notes" in the document is in the context of deprecating, removing, or breaking things, with one exception: > Relnotes:    If the change is a candidate for inclusion in the release notes for the next release from the branch, set to yes. > > RELNOTES should be for all changes that have user visible impact > of any type. > >> -Ryan