From owner-svn-src-head@FreeBSD.ORG Fri Mar 30 13:30:48 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5C3331065670; Fri, 30 Mar 2012 13:30:48 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from fep11.mx.upcmail.net (fep11.mx.upcmail.net [62.179.121.31]) by mx1.freebsd.org (Postfix) with ESMTP id 33D878FC17; Fri, 30 Mar 2012 13:30:46 +0000 (UTC) Received: from edge03.upcmail.net ([192.168.13.238]) by viefep11-int.chello.at (InterMail vM.8.01.05.04 201-2260-151-105-20111014) with ESMTP id <20120330133045.PMAG993.viefep11-int.chello.at@edge03.upcmail.net>; Fri, 30 Mar 2012 15:30:45 +0200 Received: from mole.fafoe.narf.at ([80.109.55.137]) by edge03.upcmail.net with edge id rpWl1i00f2xdvHc03pWl34; Fri, 30 Mar 2012 15:30:45 +0200 X-SourceIP: 80.109.55.137 Received: by mole.fafoe.narf.at (Postfix, from userid 1001) id 56B896D42D; Fri, 30 Mar 2012 15:30:45 +0200 (CEST) Date: Fri, 30 Mar 2012 15:30:45 +0200 From: Stefan Farfeleder To: David Xu Message-ID: <20120330133045.GD1423@mole.fafoe.narf.at> References: <201203301257.q2UCvE4l042042@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <201203301257.q2UCvE4l042042@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233700 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2012 13:30:48 -0000 --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, here are a few similar cases. Stefan --huq684BweRXVnRxX Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="extra-semicolon-if.diff" Index: tools/regression/lib/libc/nss/test-gethostby.c =================================================================== --- tools/regression/lib/libc/nss/test-gethostby.c (revision 233700) +++ tools/regression/lib/libc/nss/test-gethostby.c (working copy) @@ -109,7 +109,7 @@ else { error = 0; he = getipnodebyname(name, af, ipnode_flags, &error); - if (he == NULL); + if (he == NULL) errno = error; } Index: cddl/compat/opensolaris/misc/deviceid.c =================================================================== --- cddl/compat/opensolaris/misc/deviceid.c (revision 233700) +++ cddl/compat/opensolaris/misc/deviceid.c (working copy) @@ -45,7 +45,7 @@ return (EINVAL); } *retminor_name = strdup(""); - if (*retminor_name == NULL); + if (*retminor_name == NULL) return (ENOMEM); return (0); } Index: sys/sparc64/pci/fire.c =================================================================== --- sys/sparc64/pci/fire.c (revision 233700) +++ sys/sparc64/pci/fire.c (working copy) @@ -446,7 +446,7 @@ FO_PCI_TLU_CTRL_CFG_MASK) >> FO_PCI_TLU_CTRL_CFG_SHFT; i = sizeof(fire_freq_nak_tmr_thrs) / sizeof(*fire_freq_nak_tmr_thrs); - if (mps >= i); + if (mps >= i) mps = i - 1; FIRE_PCI_SET(sc, FO_PCI_LPU_TXLNK_FREQ_LAT_TMR_THRS, (fire_freq_nak_tmr_thrs[mps][lw] << Index: sys/contrib/rdma/rdma_addr.c =================================================================== --- sys/contrib/rdma/rdma_addr.c (revision 233700) +++ sys/contrib/rdma/rdma_addr.c (working copy) @@ -172,7 +172,7 @@ *dst = *dst_in; rtalloc(&iproute); - if (iproute.ro_rt == NULL); + if (iproute.ro_rt == NULL) return; arpresolve(iproute.ro_rt->rt_ifp, iproute.ro_rt, NULL, Index: sys/dev/gpio/gpioc.c =================================================================== --- sys/dev/gpio/gpioc.c (revision 233700) +++ sys/dev/gpio/gpioc.c (working copy) @@ -102,7 +102,7 @@ struct gpioc_softc *sc = device_get_softc(dev); int err; - if (sc->sc_ctl_dev); + if (sc->sc_ctl_dev) destroy_dev(sc->sc_ctl_dev); if ((err = bus_generic_detach(dev)) != 0) --huq684BweRXVnRxX--