From nobody Mon Mar 11 07:42:54 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TtTJy0C91z5Dtgk; Mon, 11 Mar 2024 07:42:58 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TtTJx4S2Pz4Yjr; Mon, 11 Mar 2024 07:42:57 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710142977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5yjOsQCMzYeeYOdnOWlAYGd/MP1SGBvEn+Dx1C2XLFk=; b=p3bFsIIkgbtNmetEzOiU8O3JyEysQLodqIsvZKT2+Yj007gyt4FjKkA7CAkhbYJxlkMrE+ TItCmiVb/aVrJ/U/EB8cni46c/b0/xCvSSkwjczr5UiFtlXxgqrn8NJQ6/6f40uFVgTbt3 txU7noZkiGSe0vh6I+66rGkhHW+hQah2K2DdGCUJ+2Oq77RJO80gfz3SrpyoIhUQlBbm6L OVJQotVOi689yksTCsfnrZ0zJ+j0Zc+MD0eB4csS9xqOfBAhP9E0keHB/mi3hrggBGSL29 T0tCFeWD7/DRQ1dzIAyE9P3oefjFal+UM7SStUx3RxL5bBFzWnWfZA7AnbmgTw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710142977; a=rsa-sha256; cv=none; b=B1V0uN1KL791n0l1RQqh/9KjdRVKbnOAFlZ2ALXemu7hc1TbiTaV4u5OJt7r8kbx1Stodx nbJn/sxtEyJETu4/OWGipnG6UjO+3PU1P/DLpJiiIlWiZHL1WJOumMJ9uWTYYMFiIkRbiF sdIs8v3sJ+lkf0jj5P1ZZzi3B+lBWJxnzEH8xkS9nSm6+AcSZuCziAwv3KDWpmrL2A6GKA 1LK6CToB53uGXnY17U7X2KEyPDo+DhWB+/cnQZzZAfcEEYv8Fic030Ahcoxa8JAt8Vt3LC FD2/fHf+QbzuPGe648GT6aEtFdjs3UrPJ+SNFuSaVZ0i4KY9K7WGd43MEA86WQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710142977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5yjOsQCMzYeeYOdnOWlAYGd/MP1SGBvEn+Dx1C2XLFk=; b=AsCHlyrfGvOiRobC5ZVdgdRlas4a7YYUgeZ3d5CZi9D3LYvhPtbb85sVTHsjxVlBskXnMn 2YN3vM15kvpkTpuTS4DzVI3f1/jqg2KNJDHB+J5Iy3ovSjJpO8/QQAc4wQSOg6FLIH4iui 639223dqtRyUQTEK7GIbyGnEaezXokMI0LvZeUAokgaPcCqYeotqrMTE/4E38+oD1AzlN+ f2mNxBSO+IzZPjTq5H+ptLkpIU56mFqaEfY2YYYJOJ7K5gbb80E58oYxvOcvS2CcWZjYZ8 UjaiKRi5B3678Vj/ycSeSWoVkK62UNwRfCLmrKqvB2j43atpHRLoCX42fbB6UQ== Received: from relay.mat.cc (cow.mat.cc [IPv6:2a01:678:2:200::49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TtTJx3RqnzhWr; Mon, 11 Mar 2024 07:42:57 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:224a:3414:e625:ddd5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id 4531A20152; Mon, 11 Mar 2024 08:42:56 +0100 (CET) Date: Mon, 11 Mar 2024 08:42:54 +0100 From: Mathieu Arnold To: Vladimir Druzenko Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 79f8f9c8f54b - main - */*: convert Makefile patches to MAKE_ARGS after "Move man pages to share/man" Message-ID: References: <202403102258.42AMwcEk042464@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fdlqwi3ohdlny2jk" Content-Disposition: inline In-Reply-To: <202403102258.42AMwcEk042464@gitrepo.freebsd.org> --fdlqwi3ohdlny2jk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 10, 2024 at 10:58:38PM +0000, Vladimir Druzenko wrote: > The branch main has been updated by vvd: >=20 > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D79f8f9c8f54b8de3d324d30c= e9a19649bbe69e69 >=20 > commit 79f8f9c8f54b8de3d324d30ce9a19649bbe69e69 > Author: Vladimir Druzenko > AuthorDate: 2024-03-10 22:49:41 +0000 > Commit: Vladimir Druzenko > CommitDate: 2024-03-10 22:49:41 +0000 >=20 > */*: convert Makefile patches to MAKE_ARGS after "Move man pages to s= hare/man" > =20 > Replaced patches for Makefiles with "MAKE_ARGS+=3DMANDIR=3D${PREFIX}/= share/man" Why +=3D ? Is the variable defined before in the Makefile ? If it is, then you should append to its previous value, if it is not, +=3D will only confuse people in the future, wondering why a non existing variable is appended to instead of being set. --=20 Mathieu Arnold --fdlqwi3ohdlny2jk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXutf1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6F7Qv/a5tdYS3Zo+5phO7rmJTUUwpWiOXwhFEK9glPxYOqxkcXwvY5E/BMyFLc WhzuFuCaUHqykB96HYf7Pjmev4DzeM4izYym/NSacc5ubhbloaG3WQrv6kgHZXrB JL6QtYDQm+wg4XH4vEm7Jwd1GjjVPH0shZ3Xffk/UeQacjym15BbLHwyL/wb34su eyXzBPExwmJIQT0sWd7AMveM8sKi4p2L9dZdwwNiCws+iKjMEHtYiDaOwKG0w1TB okfw6CxEqbYmK5MHamMTJ30qAsreN4ltNrtc45F1oiWSGjYRan2pRTIUZtVIGcjT 95Rnfe7qM617gqpP8faT9fWxX6mtvCmsCs30tnAt2joCh1lKnb8PYukiX1q5grsz E4ayr7VUQ5xJWkuj+g4V34v+KSfA5U59EGA/vDWzCD67of/hihNjHnUiigXEmXK/ EcR+A3M8F2HsPIs9BlPhyvlPhb4gbWqpjGJXezWh/50rgK5PgERF/NQL+NVzj56m e1JF9uV6 =N6DB -----END PGP SIGNATURE----- --fdlqwi3ohdlny2jk--