From owner-svn-src-head@freebsd.org Wed May 9 21:05:10 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BB42FCC491; Wed, 9 May 2018 21:05:10 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BA9526E929; Wed, 9 May 2018 21:05:09 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from helicon.physics.ucla.edu (helicon.physics.ucla.edu [169.232.156.253]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id w49KsRQr029793 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 9 May 2018 13:54:28 -0700 Subject: Re: svn commit: r333436 - in head/etc: etc.aarch64 etc.amd64 etc.arm etc.i386 etc.powerpc etc.riscv etc.sparc64 To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201805092049.w49Kn1QT076817@repo.freebsd.org> From: Nathan Whitehorn Message-ID: <688d1720-f1a1-0592-5807-3417d6dc6095@freebsd.org> Date: Wed, 9 May 2018 13:54:27 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <201805092049.w49Kn1QT076817@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVZOYxYpkZwsTfsk7IawoYEeu3+MN2MnyOh0bSwG8QUDPNyqdgT6xLUn6X2Xmy2BVd7gcJ198c3AwofAHNfm+zqeKN8K3RLentk= X-Sonic-ID: C;GCyYKctT6BG9ePMiNyVX4g== M;ktPpKctT6BG9ePMiNyVX4g== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 21:05:10 -0000 Thanks! At this point, these files only differ from each other in white space, comments, and whether they have video console lines at all, which is made unnecessary by this commit --- with the exception of sparc64, which has a few extra off-by-default console options. Any reason not to unify them? Or is that a follow-up commit? -Nathan On 05/09/18 13:49, Warner Losh wrote: > Author: imp > Date: Wed May 9 20:49:00 2018 > New Revision: 333436 > URL: https://svnweb.freebsd.org/changeset/base/333436 > > Log: > For video consoles, only launch a getty if the device exists. > > Differential Revision: https://reviews.freebsd.org/D15169 > > Modified: > head/etc/etc.aarch64/ttys > head/etc/etc.amd64/ttys > head/etc/etc.arm/ttys > head/etc/etc.i386/ttys > head/etc/etc.powerpc/ttys > head/etc/etc.riscv/ttys > head/etc/etc.sparc64/ttys > > Modified: head/etc/etc.aarch64/ttys > ============================================================================== > --- head/etc/etc.aarch64/ttys Wed May 9 20:41:03 2018 (r333435) > +++ head/etc/etc.aarch64/ttys Wed May 9 20:49:00 2018 (r333436) > @@ -29,16 +29,16 @@ > # when going to single-user mode. > console none unknown off secure > # > -ttyv0 "/usr/libexec/getty Pc" xterm onifconsole secure > +ttyv0 "/usr/libexec/getty Pc" xterm onifexists secure > # Virtual terminals > -ttyv1 "/usr/libexec/getty Pc" xterm off secure > -ttyv2 "/usr/libexec/getty Pc" xterm off secure > -ttyv3 "/usr/libexec/getty Pc" xterm off secure > -ttyv4 "/usr/libexec/getty Pc" xterm off secure > -ttyv5 "/usr/libexec/getty Pc" xterm off secure > -ttyv6 "/usr/libexec/getty Pc" xterm off secure > -ttyv7 "/usr/libexec/getty Pc" xterm off secure > -#ttyv8 "/usr/local/bin/xdm -nodaemon" xterm off secure > +ttyv1 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv2 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv3 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv4 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv5 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv6 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv7 "/usr/libexec/getty Pc" xterm onifexists secure > +#ttyv8 "/usr/local/bin/xdm -nodaemon" xterm onifexists secure > # Serial terminals > # The 'dialup' keyword identifies dialin lines to login, fingerd etc. > ttyu0 "/usr/libexec/getty 3wire" vt100 onifconsole secure > > Modified: head/etc/etc.amd64/ttys > ============================================================================== > --- head/etc/etc.amd64/ttys Wed May 9 20:41:03 2018 (r333435) > +++ head/etc/etc.amd64/ttys Wed May 9 20:49:00 2018 (r333436) > @@ -29,15 +29,15 @@ > # when going to single-user mode. > console none unknown off secure > # > -ttyv0 "/usr/libexec/getty Pc" xterm on secure > +ttyv0 "/usr/libexec/getty Pc" xterm onifexists secure > # Virtual terminals > -ttyv1 "/usr/libexec/getty Pc" xterm on secure > -ttyv2 "/usr/libexec/getty Pc" xterm on secure > -ttyv3 "/usr/libexec/getty Pc" xterm on secure > -ttyv4 "/usr/libexec/getty Pc" xterm on secure > -ttyv5 "/usr/libexec/getty Pc" xterm on secure > -ttyv6 "/usr/libexec/getty Pc" xterm on secure > -ttyv7 "/usr/libexec/getty Pc" xterm on secure > +ttyv1 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv2 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv3 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv4 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv5 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv6 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv7 "/usr/libexec/getty Pc" xterm onifexists secure > ttyv8 "/usr/local/bin/xdm -nodaemon" xterm off secure > # Serial terminals > # The 'dialup' keyword identifies dialin lines to login, fingerd etc. > > Modified: head/etc/etc.arm/ttys > ============================================================================== > --- head/etc/etc.arm/ttys Wed May 9 20:41:03 2018 (r333435) > +++ head/etc/etc.arm/ttys Wed May 9 20:49:00 2018 (r333436) > @@ -29,15 +29,15 @@ > # when going to single-user mode. > console none unknown off secure > # > -ttyv0 "/usr/libexec/getty Pc" xterm onifconsole secure > +ttyv0 "/usr/libexec/getty Pc" xterm onifexists secure > # Virtual terminals > -ttyv1 "/usr/libexec/getty Pc" xterm off secure > -ttyv2 "/usr/libexec/getty Pc" xterm off secure > -ttyv3 "/usr/libexec/getty Pc" xterm off secure > -ttyv4 "/usr/libexec/getty Pc" xterm off secure > -ttyv5 "/usr/libexec/getty Pc" xterm off secure > -ttyv6 "/usr/libexec/getty Pc" xterm off secure > -ttyv7 "/usr/libexec/getty Pc" xterm off secure > +ttyv1 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv2 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv3 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv4 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv5 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv6 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv7 "/usr/libexec/getty Pc" xterm onifexists secure > #ttyv8 "/usr/local/bin/xdm -nodaemon" xterm off secure > # Serial terminals > # The 'dialup' keyword identifies dialin lines to login, fingerd etc. > > Modified: head/etc/etc.i386/ttys > ============================================================================== > --- head/etc/etc.i386/ttys Wed May 9 20:41:03 2018 (r333435) > +++ head/etc/etc.i386/ttys Wed May 9 20:49:00 2018 (r333436) > @@ -29,15 +29,15 @@ > # when going to single-user mode. > console none unknown off secure > # > -ttyv0 "/usr/libexec/getty Pc" xterm on secure > +ttyv0 "/usr/libexec/getty Pc" xterm onifexists secure > # Virtual terminals > -ttyv1 "/usr/libexec/getty Pc" xterm on secure > -ttyv2 "/usr/libexec/getty Pc" xterm on secure > -ttyv3 "/usr/libexec/getty Pc" xterm on secure > -ttyv4 "/usr/libexec/getty Pc" xterm on secure > -ttyv5 "/usr/libexec/getty Pc" xterm on secure > -ttyv6 "/usr/libexec/getty Pc" xterm on secure > -ttyv7 "/usr/libexec/getty Pc" xterm on secure > +ttyv1 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv2 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv3 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv4 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv5 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv6 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv7 "/usr/libexec/getty Pc" xterm onifexists secure > ttyv8 "/usr/local/bin/xdm -nodaemon" xterm off secure > # Serial terminals > # The 'dialup' keyword identifies dialin lines to login, fingerd etc. > > Modified: head/etc/etc.powerpc/ttys > ============================================================================== > --- head/etc/etc.powerpc/ttys Wed May 9 20:41:03 2018 (r333435) > +++ head/etc/etc.powerpc/ttys Wed May 9 20:49:00 2018 (r333436) > @@ -29,15 +29,15 @@ > # when going to single-user mode. > console none unknown off secure > # > -ttyv0 "/usr/libexec/getty Pc" xterm on secure > +ttyv0 "/usr/libexec/getty Pc" xterm onifexists secure > # Virtual terminals > -ttyv1 "/usr/libexec/getty Pc" xterm on secure > -ttyv2 "/usr/libexec/getty Pc" xterm on secure > -ttyv3 "/usr/libexec/getty Pc" xterm on secure > -ttyv4 "/usr/libexec/getty Pc" xterm on secure > -ttyv5 "/usr/libexec/getty Pc" xterm on secure > -ttyv6 "/usr/libexec/getty Pc" xterm on secure > -ttyv7 "/usr/libexec/getty Pc" xterm on secure > +ttyv1 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv2 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv3 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv4 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv5 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv6 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv7 "/usr/libexec/getty Pc" xterm onifexists secure > #ttyv8 "/usr/local/bin/xdm -nodaemon" xterm off secure > # Serial terminals > # The 'dialup' keyword identifies dialin lines to login, fingerd etc. > > Modified: head/etc/etc.riscv/ttys > ============================================================================== > --- head/etc/etc.riscv/ttys Wed May 9 20:41:03 2018 (r333435) > +++ head/etc/etc.riscv/ttys Wed May 9 20:49:00 2018 (r333436) > @@ -29,16 +29,16 @@ > # when going to single-user mode. > console none unknown off secure > # > -ttyv0 "/usr/libexec/getty Pc" xterm onifconsole secure > +ttyv0 "/usr/libexec/getty Pc" xterm onifexists secure > # Virtual terminals > -ttyv1 "/usr/libexec/getty Pc" xterm off secure > -ttyv2 "/usr/libexec/getty Pc" xterm off secure > -ttyv3 "/usr/libexec/getty Pc" xterm off secure > -ttyv4 "/usr/libexec/getty Pc" xterm off secure > -ttyv5 "/usr/libexec/getty Pc" xterm off secure > -ttyv6 "/usr/libexec/getty Pc" xterm off secure > -ttyv7 "/usr/libexec/getty Pc" xterm off secure > -#ttyv8 "/usr/local/bin/xdm -nodaemon" xterm off secure > +ttyv1 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv2 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv3 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv4 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv5 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv6 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv7 "/usr/libexec/getty Pc" xterm onifexists secure > +#ttyv8 "/usr/local/bin/xdm -nodaemon" xterm onifexists secure > # Serial terminals > # The 'dialup' keyword identifies dialin lines to login, fingerd etc. > ttyu0 "/usr/libexec/getty 3wire" vt100 onifconsole secure > > Modified: head/etc/etc.sparc64/ttys > ============================================================================== > --- head/etc/etc.sparc64/ttys Wed May 9 20:41:03 2018 (r333435) > +++ head/etc/etc.sparc64/ttys Wed May 9 20:49:00 2018 (r333436) > @@ -33,15 +33,15 @@ screen "/usr/libexec/getty Pc" vt100 off secure > ttya "/usr/libexec/getty 3wire.9600" vt100 off secure > ttyb "/usr/libexec/getty 3wire.9600" vt100 off secure > # syscons(4) > -ttyv0 "/usr/libexec/getty Pc" xterm on secure > +ttyv0 "/usr/libexec/getty Pc" xterm onifexists secure > # Virtual terminals > -ttyv1 "/usr/libexec/getty Pc" xterm on secure > -ttyv2 "/usr/libexec/getty Pc" xterm on secure > -ttyv3 "/usr/libexec/getty Pc" xterm on secure > -ttyv4 "/usr/libexec/getty Pc" xterm on secure > -ttyv5 "/usr/libexec/getty Pc" xterm on secure > -ttyv6 "/usr/libexec/getty Pc" xterm on secure > -ttyv7 "/usr/libexec/getty Pc" xterm on secure > +ttyv1 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv2 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv3 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv4 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv5 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv6 "/usr/libexec/getty Pc" xterm onifexists secure > +ttyv7 "/usr/libexec/getty Pc" xterm onifexists secure > ttyv8 "/usr/local/bin/xdm -nodaemon" xterm off secure > # Serial terminals > # The 'dialup' keyword identifies dialin lines to login, fingerd etc. >