From owner-svn-src-head@freebsd.org Wed Mar 1 16:44:01 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0AEAECF1423; Wed, 1 Mar 2017 16:44:01 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B2A63E35; Wed, 1 Mar 2017 16:43:59 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v21GhuuZ057214; Wed, 1 Mar 2017 08:43:56 -0800 (PST) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v21GhtaI057213; Wed, 1 Mar 2017 08:43:55 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201703011643.v21GhtaI057213@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r314464 - head/usr.sbin/yppush In-Reply-To: <20170301163050.GA81295@FreeBSD.org> To: Alexey Dokuchaev Date: Wed, 1 Mar 2017 08:43:55 -0800 (PST) CC: Ian Lepore , "Ngie Cooper (yaneurabeya)" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Ngie Cooper X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 16:44:01 -0000 > On Wed, Mar 01, 2017 at 08:54:51AM -0700, Ian Lepore wrote: > > ... > > You're not the only one who has diffed build output logs (I suspect > > anyone who has to maintain a non-trivial build infrastructure has done > > so), and you're not the only one who thinks that changing relative > > paths to absolute is a bad idea. > > +1. Relative paths are so much nicer (and they are usually shorter as > well). I didn't respond to these changes only because .CURDIR itself > is expanded to a full path, so arguing if one wants some ../../ within > what's inherently starts with a slash seems pointless. True, in the normal use relative paths are shorter, but in how this actually all goes about the use of ${SRCTOP} vs ${.CURDIR} yeilds both short strings in the Makefile, and shorter output in the log. Your reasoning is also why I was somewhat quiet on it when I saw it start to be merged into -stable, which was the first place I saw it. I *thought* at that point the whole of -current had already been converted and this was just coming over with other nearby changes. I believe we have some other full path things that have crept forward into the production release, but that may be in ports only. Nope bad full paths links I found in just a few seconds: lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 chfn -> /usr/bin/chpass lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 chsh -> /usr/bin/chpass lrwxr-xr-x 1 root wheel 7 Nov 30 02:27 cpio -> bsdcpio lrwxr-xr-x 1 root wheel 21 Nov 30 02:27 mailq -> /usr/sbin/mailwrapper lrwxr-xr-x 1 root wheel 21 Nov 30 02:27 newaliases -> /usr/sbin/mailwrapper lrwxr-xr-x 1 root wheel 10 Nov 30 02:25 pgrep -> /bin/pgrep lrwxr-xr-x 1 root wheel 10 Nov 30 02:25 pkill -> /bin/pkill lrwxr-xr-x 1 root wheel 6 Nov 30 02:27 tar -> bsdtar lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchfn -> /usr/bin/chpass lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchpass -> /usr/bin/chpass lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchsh -> /usr/bin/chpass lrwxr-xr-x 1 root wheel 15 Nov 30 02:27 yppasswd -> /usr/bin/passwd This breaks the abilty to mv usr/bin and have the right stuff happen if you invoke usr/bin.moved/mailq. -- Rod Grimes rgrimes@freebsd.org