From owner-svn-src-all@freebsd.org  Fri Jan  5 13:54:11 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46130EAA9AA;
 Fri,  5 Jan 2018 13:54:11 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 045F26A0B9;
 Fri,  5 Jan 2018 13:54:11 +0000 (UTC) (envelope-from slw@zxy.spb.ru)
Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD))
 (envelope-from <slw@zxy.spb.ru>)
 id 1eXRm6-000LQ3-3D; Fri, 05 Jan 2018 16:11:06 +0300
Date: Fri, 5 Jan 2018 16:11:06 +0300
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: Eugene Grosbein <eugen@grosbein.net>
Cc: Steven Hartland <smh@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r327559 - in head: . sys/net
Message-ID: <20180105131105.GB5368@zxy.spb.ru>
References: <201801042005.w04K5liB049411@repo.freebsd.org>
 <5A4E9397.9000308@grosbein.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5A4E9397.9000308@grosbein.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: slw@zxy.spb.ru
X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jan 2018 13:54:11 -0000

On Fri, Jan 05, 2018 at 03:50:31AM +0700, Eugene Grosbein wrote:

> 05.01.2018 3:05, Steven Hartland wrote:
> 
> > Author: smh
> > Date: Thu Jan  4 20:05:47 2018
> > New Revision: 327559
> > URL: https://svnweb.freebsd.org/changeset/base/327559
> > 
> > Log:
> >   Disabled the use of flowid for lagg by default
> >   
> >   Disabled the use of RSS hash from the network card aka flowid for
> >   lagg(4) interfaces by default as it's currently incompatible with
> >   the lacp and loadbalance protocols.
> >   
> >   The incompatibility is due to the fact that the flowid isn't know
> >   for the first packet of a new outbound stream which can result in
> >   the hash calculation method changing and hence a stream being
> >   incorrectly split across multiple interfaces during normal
> >   operation.
> >   
> >   This can be re-enabled by setting the following in loader.conf:
> >   net.link.lagg.default_use_flowid="1"
> >   
> >   Discussed with: kmacy
> >   Sponsored by:	Multiplay
> 
> RSS by definition has meaning to received stream. What is "outbound" stream
> in this context, why can the hash calculatiom method change and what exactly
> does it mean "a stream being incorrectly split"?
> 
> Defaults should not be changed so easily just because they are not optimal
> for some specific case. Each lagg has its own setting for flowid usage
> and why one cannot just use "ifconfig lagg0 -use_flowid" for such cases?

Irrelevant to RSS and etc. flowid distribution in lacp case work very
bad. This is good and must be MFC (IMHO).