Date: Sat, 6 Aug 2016 15:08:32 -0400 (EDT) From: Benjamin Kaduk <bjk@freebsd.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303801 - head/share/man/man3 Message-ID: <alpine.GSO.1.10.1608061508060.5272@multics.mit.edu> In-Reply-To: <CAG6CVpWeJb93jG9diN=09MYP--vC4SQ3-v0nQx8-4VjRMOB1mQ@mail.gmail.com> References: <201608061727.u76HR7TQ000766@repo.freebsd.org> <CAG6CVpWeJb93jG9diN=09MYP--vC4SQ3-v0nQx8-4VjRMOB1mQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Indeed; it seems I was not checking what I thought I was checking in sys/queue.h; fix incoming. -Ben On Sat, 6 Aug 2016, Conrad Meyer wrote: > Hey Benjamin, > > The submitter notes that this wider change isn't quite right in > https://reviews.freebsd.org/D7428 =E2=80=94 LIST_SWAP and TAILQ_SWAP both= need > the "entry" parameter. > > Best, > Conrad > > On Sat, Aug 6, 2016 at 10:27 AM, Benjamin Kaduk <bjk@freebsd.org> wrote: > > Author: bjk (doc committer) > > Date: Sat Aug 6 17:27:07 2016 > > New Revision: 303801 > > URL: https://svnweb.freebsd.org/changeset/base/303801 > > > > Log: > > Correct the documentation of the 'type' parameter for the _SWAP > > macros from sys/queue.h > > > > Submitted by: akshay1994.leo_gmail.com (for STAILQ) > > Differential Revision: https://reviews.freebsd.org/D7428 > > > > Modified: > > head/share/man/man3/queue.3 > > > > Modified: head/share/man/man3/queue.3 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/share/man/man3/queue.3 Sat Aug 6 17:24:35 2016 (r30380= 0) > > +++ head/share/man/man3/queue.3 Sat Aug 6 17:27:07 2016 (r30380= 1) > > @@ -141,7 +141,7 @@ lists and tail queues > > .Fn SLIST_REMOVE "SLIST_HEAD *head" "TYPE *elm" "TYPE" "SLIST_ENTRY NA= ME" > > .Fn SLIST_REMOVE_AFTER "TYPE *elm" "SLIST_ENTRY NAME" > > .Fn SLIST_REMOVE_HEAD "SLIST_HEAD *head" "SLIST_ENTRY NAME" > > -.Fn SLIST_SWAP "SLIST_HEAD *head1" "SLIST_HEAD *head2" "SLIST_ENTRY NA= ME" > > +.Fn SLIST_SWAP "SLIST_HEAD *head1" "SLIST_HEAD *head2" "TYPE" > > .\" > > .Fn STAILQ_CLASS_ENTRY "CLASSTYPE" > > .Fn STAILQ_CLASS_HEAD "HEADNAME" "CLASSTYPE" > > @@ -164,7 +164,7 @@ lists and tail queues > > .Fn STAILQ_REMOVE "STAILQ_HEAD *head" "TYPE *elm" "TYPE" "STAILQ_ENTRY= NAME" > > .Fn STAILQ_REMOVE_AFTER "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY = NAME" > > .Fn STAILQ_REMOVE_HEAD "STAILQ_HEAD *head" "STAILQ_ENTRY NAME" > > -.Fn STAILQ_SWAP "STAILQ_HEAD *head1" "STAILQ_HEAD *head2" "STAILQ_ENTR= Y NAME" > > +.Fn STAILQ_SWAP "STAILQ_HEAD *head1" "STAILQ_HEAD *head2" "TYPE" > > .\" > > .Fn LIST_CLASS_ENTRY "CLASSTYPE" > > .Fn LIST_CLASS_HEAD "HEADNAME" "CLASSTYPE" > > @@ -184,7 +184,7 @@ lists and tail queues > > .Fn LIST_NEXT "TYPE *elm" "LIST_ENTRY NAME" > > .Fn LIST_PREV "TYPE *elm" "LIST_HEAD *head" "TYPE" "LIST_ENTRY NAME" > > .Fn LIST_REMOVE "TYPE *elm" "LIST_ENTRY NAME" > > -.Fn LIST_SWAP "LIST_HEAD *head1" "LIST_HEAD *head2" "TYPE" "LIST_ENTRY= NAME" > > +.Fn LIST_SWAP "LIST_HEAD *head1" "LIST_HEAD *head2" "TYPE" > > .\" > > .Fn TAILQ_CLASS_ENTRY "CLASSTYPE" > > .Fn TAILQ_CLASS_HEAD "HEADNAME" "CLASSTYPE" > > @@ -211,7 +211,7 @@ lists and tail queues > > .Fn TAILQ_NEXT "TYPE *elm" "TAILQ_ENTRY NAME" > > .Fn TAILQ_PREV "TYPE *elm" "HEADNAME" "TAILQ_ENTRY NAME" > > .Fn TAILQ_REMOVE "TAILQ_HEAD *head" "TYPE *elm" "TAILQ_ENTRY NAME" > > -.Fn TAILQ_SWAP "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TYPE" "TAILQ_E= NTRY NAME" > > +.Fn TAILQ_SWAP "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TYPE" > > .\" > > .Sh DESCRIPTION > > These macros define and operate on four types of data structures which > > > From owner-svn-src-head@freebsd.org Sat Aug 6 20:13:03 2016 Return-Path: <owner-svn-src-head@freebsd.org> Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6AF93BB1B5F for <svn-src-head@mailman.ysv.freebsd.org>; Sat, 6 Aug 2016 20:13:03 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yb0-x22c.google.com (mail-yb0-x22c.google.com [IPv6:2607:f8b0:4002:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3003A1A24 for <svn-src-head@freebsd.org>; Sat, 6 Aug 2016 20:13:03 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yb0-x22c.google.com with SMTP id x196so24810190ybe.1 for <svn-src-head@freebsd.org>; Sat, 06 Aug 2016 13:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VgbVnBoBThU7FM3nUePjWMeY5pzgdCzLbRzGYwOOlPA=; b=tOTU2T4AcNGWOBZ+9MQTdb0nKB5f3vCGpuQeNu0NU22XRdSRoxKxnHyUxniB3lp0xF Scucc8EG0UmRfn9WDfCyYaaUttMYfxH9zWnun3ezLeYIFL4KZ4ckpE0UfylEL5RJ5OW0 A/xD09IPglvEB42pb2glYIo0vpVpemq7Vv5xZB7C6jaG1Ym7TTAsuAe3CFJY/BixKbfr fPbSiZby+RmfhTstzlTsUiVw5EylsMmSX9Au8oaRlDOjqbFFmefUwJU66X9QYu/yfkID lrTb/nu6Abi5zgLQSFQNHJtbqiTPTec0njFmXAR2MVK/jy112VPOH/3IJqWPtLcGEJ0K cUYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VgbVnBoBThU7FM3nUePjWMeY5pzgdCzLbRzGYwOOlPA=; b=BjePurDWcVATU1XKQ9CSPKJQmS0kIqwnBQ19eBECjLFzbq04maTGT2eOHOkBf+nsU8 Aa1S9bcUgZll0sYqJyYMzLKBVCS6Nm/sLZb3SEn77ihF1vNwDPRUaXyYXKekJrRKXz0l mUkmHyF2WGiSxzKEggstwRNHdj3kQHbJfnDKpYKBpdv6c6OKXk4c7kmkokTMFSXzdAVh x9rbPQZOxdalqJUqy8ROQOa7Cm+UmRyA838TCU18U4th+gJiWT/WVp7KbxmyrqlxHD2n i0+UVVNbc5v5IxZWVdhVIJkccU7hkXJe2Dkns79Cz/rgA7rZm8gZ5DYgwwLKXEgJ1o5h F6Kw== X-Gm-Message-State: AEkoouusGDCHvrGWye7rsT96MbfsTuIGOtZ/pHd/UOE9LAzLyI/tqzNwZeW7I+wS8tFGVVtQpO3KZ0FvkoEAmQ== X-Received: by 10.37.161.136 with SMTP id a8mr25574098ybi.16.1470514382043; Sat, 06 Aug 2016 13:13:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.201.71 with HTTP; Sat, 6 Aug 2016 13:13:01 -0700 (PDT) In-Reply-To: <201608041527.u74FR9xo083057@repo.freebsd.org> References: <201608041527.u74FR9xo083057@repo.freebsd.org> From: Ed Schouten <ed@nuxi.nl> Date: Sat, 6 Aug 2016 22:13:01 +0200 Message-ID: <CABh_MKkD2N4YXEJGHA14zavYuF_PmwDei6tjKTm4kC4mr1MY=Q@mail.gmail.com> Subject: Re: svn commit: r303746 - head/usr.bin/indent To: "Pedro F. Giffuni" <pfg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current <svn-src-head.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>; List-Post: <mailto:svn-src-head@freebsd.org> List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 06 Aug 2016 20:13:03 -0000 Hi Pedro, 2016-08-04 17:27 GMT+02:00 Pedro F. Giffuni <pfg@freebsd.org>: > Log: > indent(1): Use bsearch() for looking up type keywords. You're never doing any deletions, right? Would it make more sense to use hsearch_r() in that case? -- Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.GSO.1.10.1608061508060.5272>