From owner-svn-src-head@freebsd.org  Wed Jan 27 11:16:12 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2EC7A6ECCF;
 Wed, 27 Jan 2016 11:16:12 +0000 (UTC) (envelope-from br@bsdpad.com)
Received: from bsdpad.com (xc1.bsdpad.com [195.154.136.64])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8E063104C;
 Wed, 27 Jan 2016 11:16:11 +0000 (UTC) (envelope-from br@bsdpad.com)
Received: from localhost ([127.0.0.1] helo=bsdpad.com)
 by bsdpad.com with smtp (Exim 4.83 (FreeBSD))
 (envelope-from <br@bsdpad.com>)
 id 1aONsQ-000NzO-CE; Wed, 27 Jan 2016 11:03:06 +0000
Received: by bsdpad.com (nbSMTP-1.00) for uid 1001
 br@bsdpad.com; Wed, 27 Jan 2016 11:03:06 +0000 (GMT)
Date: Wed, 27 Jan 2016 11:03:06 +0000
From: Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk>
To: Devin Teske <dteske@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r294893 - head/lib/libdpv
Message-ID: <20160127110306.GA92213@bsdpad.com>
References: <201601270621.u0R6LZPd030494@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <201601270621.u0R6LZPd030494@repo.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jan 2016 11:16:12 -0000

I get this with GCC 5.2.0:

/home/rb743/dev/freebsd-riscv/lib/libdpv/dialog_util.c:270:23: error: zero-length gnu_printf format string [-Werror=for
mat-zero-length]
   sprintf(dargv[n++], "");

Ruslan

On Wed, Jan 27, 2016 at 06:21:35AM +0000, Devin Teske wrote:
> Author: dteske
> Date: Wed Jan 27 06:21:35 2016
> New Revision: 294893
> URL: https://svnweb.freebsd.org/changeset/base/294893
> 
> Log:
>   Fix a crash if `-D' is used without `-t title'
>   
>   dialog(3)'s dlg_reallocate_gauge(), used both by dialog(3)'s dialog_gauge()
>   and dialog(1)'s `--gauge', will segmentation fault in strlen(3) if no title
>   is set for the widget. Reproducible with `dialog --gauge hi 6 20' (adding
>   `--title ""' is enough to prevent segmentation fault).
>   
>   MFC after:	3 days
>   X-MFC-to:	stable/10
> 
> Modified:
>   head/lib/libdpv/dialog_util.c
> 
> Modified: head/lib/libdpv/dialog_util.c
> ==============================================================================
> --- head/lib/libdpv/dialog_util.c	Wed Jan 27 06:16:53 2016	(r294892)
> +++ head/lib/libdpv/dialog_util.c	Wed Jan 27 06:21:35 2016	(r294893)
> @@ -261,6 +261,13 @@ dialog_spawn_gauge(char *init_prompt, pi
>  			errx(EXIT_FAILURE, "Out of memory?!");
>  		sprintf(dargv[n++], "--title");
>  		dargv[n++] = title;
> +	} else {
> +		if ((dargv[n] = malloc(8)) == NULL)
> +			errx(EXIT_FAILURE, "Out of memory?!");
> +		sprintf(dargv[n++], "--title");
> +		if ((dargv[n] = malloc(8)) == NULL)
> +			errx(EXIT_FAILURE, "Out of memory?!");
> +		sprintf(dargv[n++], "");
>  	}
>  	if (backtitle != NULL) {
>  		if ((dargv[n] = malloc(12)) == NULL)
>