From owner-svn-src-head@FreeBSD.ORG Sat Jun 29 15:12:39 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B59BD9D5; Sat, 29 Jun 2013 15:12:39 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from nibbler.fubar.geek.nz (nibbler.fubar.geek.nz [199.48.134.198]) by mx1.freebsd.org (Postfix) with ESMTP id 9AACF19AC; Sat, 29 Jun 2013 15:12:39 +0000 (UTC) Received: from bender.Home (97e76fc9.skybroadband.com [151.231.111.201]) by nibbler.fubar.geek.nz (Postfix) with ESMTPSA id 537A95E200; Sat, 29 Jun 2013 15:12:32 +0000 (UTC) Date: Sat, 29 Jun 2013 16:12:25 +0100 From: Andrew Turner To: Aleksandr Rybalko Subject: Re: svn commit: r252372 - head/sys/arm/arm Message-ID: <20130629161225.45677820@bender.Home> In-Reply-To: <201306291227.r5TCRoRM063915@svn.freebsd.org> References: <201306291227.r5TCRoRM063915@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ruslan Bukin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jun 2013 15:12:39 -0000 On Sat, 29 Jun 2013 12:27:50 +0000 (UTC) Aleksandr Rybalko wrote: > Author: ray > Date: Sat Jun 29 12:27:50 2013 > New Revision: 252372 > URL: http://svnweb.freebsd.org/changeset/base/252372 > > Log: > Add ARM Generic Timer driver. > > Submitted by: Ruslan Bukin > > Added: > head/sys/arm/arm/generic_timer.c (contents, props changed) > > Added: head/sys/arm/arm/generic_timer.c ... > +static inline void > +disable_user_access(void) > +{ > + uint32_t cntkctl; > + > + __asm volatile("mrc p15, 0, %0, c14, c1, 0" : > "=r" (cntkctl)); > + cntkctl &= ~((3 << 8) | (7 << 0)); What do these magic numbers do? I.e. could they be macros so the values are described. Andrew