From owner-svn-ports-head@freebsd.org Tue Feb 23 13:07:12 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5D0EE5433B7; Tue, 23 Feb 2021 13:07:12 +0000 (UTC) (envelope-from thomas@bsdunix.ch) Received: from conversation.bsdunix.ch (ns1.bsdunix.ch [82.220.1.90]) by mx1.freebsd.org (Postfix) with ESMTP id 4DlK8J1XDtz3DNL; Tue, 23 Feb 2021 13:07:10 +0000 (UTC) (envelope-from thomas@bsdunix.ch) Received: from [192.168.1.29] (dynamic-82-220-88-108.ftth.solnet.ch [82.220.88.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.bsdunix.ch (Postfix) with ESMTPSA id 4DlK806qyDz1jRb; Tue, 23 Feb 2021 13:06:56 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: svn commit: r540710 - head/sysutils/arcconf From: Thomas Vogt In-Reply-To: <2c409df4-f4e-dd6a-9688-abae25132de7@pfeifer.com> Date: Tue, 23 Feb 2021 14:06:56 +0100 Cc: Alexey Dokuchaev , Li-Wen Hsu , michael@fuckner.net, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: References: <202006281346.05SDkfaS050010@repo.freebsd.org> <3c213f5-9fb6-c09c-e436-7d4d95619d46@pfeifer.com> <20210203104306.GA8202@FreeBSD.org> <9F1E8D36-EC64-47A6-A453-8442BC819D29@bsdunix.ch> <2c409df4-f4e-dd6a-9688-abae25132de7@pfeifer.com> To: Gerald Pfeifer X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Status: No, score=3.3 required=5.0 tests=AWL,BAYES_00,HELO_MISC_IP, KHOP_HELO_FCRDNS,RCVD_IN_PBL,RDNS_DYNAMIC,SPF_NEUTRAL,TW_SV autolearn=no autolearn_force=no X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on conversation.bsdunix.ch X-Rspamd-Queue-Id: 4DlK8J1XDtz3DNL X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2021 13:07:12 -0000 > On 23 Feb 2021, at 13:42, Gerald Pfeifer wrote: > > On Wed, 3 Feb 2021, Thomas Vogt wrote: >>>>> - Update Makefile to use current version of GCC as defined in >>>>> bsd.default-versions.mk. (USE_GCC=yes) >>>> ... >>>>> LIB_DEPENDS= libstdc++.so.6:lang/gcc${GCC_DEFAULT} >>>>> +USE_GCC= yes >>>> This looks very (very) odd. >>>> >>>> USE_GCC already implies a run-time dependency on lang/gcc${GCC_DEFAULT} >>>> and I do not recall seeing such a LIB_DEPENDS before. >>>> >>>> Are you sure this is really, really needed with USE_GCC=yes? >>> I believe, seeing NO_BUILD=yes, it's because this is some sort of binary- >>> only program which links against libstdc++.so.6. I can't verify because >>> the distfile is ~73MB and that's a bit too much for me to download ATM. >> arcconf links to libstdc++.so.6. An ancient libstdc++.so.6 version was >> provided with old freebsd versions (included with an old gcc). The >> binary failed to run with: ld-elf.so.1: /usr/lib/libstdc++.so.6: >> version GLIBCXX_3.4.11 required .. >> >> Newer gcc versions from the port provided libstdc++.so.6 with >= >> GLIBCXX_3.4.11. Thats the reason why gcc was added. > > So I am wondering: Isn't USE_GCC=yes sufficient? > > USE_GCC=yes implies > RUN_DEPENDS+= ${CC}:lang/gcc${GCC_DEFAULT} > which pulls in lang/gcc${GCC_DEFAULT} and its run-time libraries at > run time. > > The LIB_DEPENDS statement above does not add to that. Yes. Maybe RUN_DEPENDS is more obvious than USE_GCC. Regards, Tom