Date: Tue, 29 Apr 2025 18:30:40 GMT From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: ab9e7d209ac5 - stable/14 - hdaa: Don't hold a mutex while creating child devices Message-ID: <202504291830.53TIUeHs022660@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=ab9e7d209ac58e9c4d0a0ebd4bdb6f96f303e8df commit ab9e7d209ac58e9c4d0a0ebd4bdb6f96f303e8df Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2025-03-10 17:34:07 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2025-04-29 14:42:56 +0000 hdaa: Don't hold a mutex while creating child devices The lock is already not held while deleting child devices, and the bus_topo_lock is already held when child devices are created. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D49272 (cherry picked from commit 02d61f27585f52d422fc1e235ac6226e27145162) --- sys/dev/sound/pci/hda/hdaa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/sound/pci/hda/hdaa.c b/sys/dev/sound/pci/hda/hdaa.c index 3220ef69776b..14306526a4e7 100644 --- a/sys/dev/sound/pci/hda/hdaa.c +++ b/sys/dev/sound/pci/hda/hdaa.c @@ -6200,7 +6200,9 @@ hdaa_configure(device_t dev) HDA_BOOTHVERBOSE( device_printf(dev, "Creating PCM devices...\n"); ); + hdaa_unlock(devinfo); hdaa_create_pcms(devinfo); + hdaa_lock(devinfo); HDA_BOOTVERBOSE( if (devinfo->quirks != 0) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202504291830.53TIUeHs022660>