From owner-cvs-all@FreeBSD.ORG Wed Sep 20 12:23:16 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB05E16A47C; Wed, 20 Sep 2006 12:23:16 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA8B343D8A; Wed, 20 Sep 2006 12:23:12 +0000 (GMT) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.13.8/8.13.8/ALCHEMY.FRANKEN.DE) with ESMTP id k8KCNBD3081569; Wed, 20 Sep 2006 14:23:11 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.13.8/8.13.8/Submit) id k8KCNBL7081568; Wed, 20 Sep 2006 14:23:11 +0200 (CEST) (envelope-from marius) Date: Wed, 20 Sep 2006 14:23:11 +0200 From: Marius Strobl To: Ruslan Ermilov Message-ID: <20060920122311.GA81536@alchemy.franken.de> References: <20060919190645.GA23068@rambler-co.ru> <20060919194819.GA23360@rambler-co.ru> <20060919203608.GE23360@rambler-co.ru> <20060919215605.GB44298@rambler-co.ru> <20060919221404.GT94944@alchemy.franken.de> <20060920055715.GA81843@rambler-co.ru> <20060920121017.GU94944@alchemy.franken.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060920121017.GU94944@alchemy.franken.de> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Maksim Yevmenkin Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2006 12:23:16 -0000 On Wed, Sep 20, 2006 at 02:10:17PM +0200, Marius Strobl wrote: > On Wed, Sep 20, 2006 at 09:57:15AM +0400, Ruslan Ermilov wrote: > > On Wed, Sep 20, 2006 at 12:14:04AM +0200, Marius Strobl wrote: > > > On Wed, Sep 20, 2006 at 01:56:05AM +0400, Ruslan Ermilov wrote: > > > > > > > > The proper fix would be to fix the kernel to pass an argument by > > > > value, like the userland does. But from the practical point of > > > > view, it may make sense to change the API and say that these > > > > IOCTLs now take a pointer type argument. I'm not sure. If you > > > > know of any applications (mine test util not counting :-) that > > > > use KDSKBMODE/KDSETLED/KDSKBSTATE, then we should probably fix > > > > the kernel callers. > > > > > > XFree86/Xorg use KDSKBMODE and KDSETLED, see f.e. the Xorg > > > "kbd" driver: > > > http://webcvs.freedesktop.org/xorg/xserver/xorg/hw/xfree86/os-support/bsd/bsd_kbd.c?revision=1.8&view=markup > > > > > Hmm, but they don't work on sparc64. How X.Org ever works then? > > I remember installing it on my sparc64 laptop... > > KDSETLED just never worked on sparc64 so far (from userland...), > keyboard LEDs just don't get lit when in X. As for KDSKBMODE > K_RAW is defined as 0 so X happens to put the keyboard into > raw mode as expected and syscons(4) makes sure that the > keyboard is in translate mode in sccngetch(). So apart from > the keyboard LEDs keyboards just happen to work in X and > when back on the console on sparc64. ...at least if one doesn't use custom keycodes in X Marius