Date: Tue, 18 Aug 2020 13:28:37 -0400 From: Ryan Stone <rysto32@gmail.com> To: freebsd-net <freebsd-net@freebsd.org> Subject: Re: Is anybody using ng_pipe? Message-ID: <CAFMmRNwAQ-x2p1CGnzyEuDREtuwS8w4SiQCqwNoKKNWxREQ_cQ@mail.gmail.com> In-Reply-To: <CAFMmRNxgoSNX2%2BLd=eEXRH0q7-XFzSF=b2GPzZgNW1LDCvq5Xw@mail.gmail.com> References: <CAFMmRNxgoSNX2%2BLd=eEXRH0q7-XFzSF=b2GPzZgNW1LDCvq5Xw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 18, 2020 at 1:17 PM Ryan Stone <rysto32@gmail.com> wrote: > 4. The table calculation had two integer truncation bugs and used the > wrong formula. I'm reasonably sure it would never calculate a > probability other than 0 due a 64-bit constant being truncated to > 32-bits. I've gone back and checked, and I was partially wrong on this point. I had gotten the idea that integer literals would be truncated to int, which is not true. The use of the wrong formula still means that packets are dropped at entirely the wrong rate, though.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNwAQ-x2p1CGnzyEuDREtuwS8w4SiQCqwNoKKNWxREQ_cQ>