From owner-freebsd-net@freebsd.org Tue Aug 18 17:28:51 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0DE7D3C24A3 for ; Tue, 18 Aug 2020 17:28:51 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWHvP6w8cz4P4C for ; Tue, 18 Aug 2020 17:28:49 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-ej1-x633.google.com with SMTP id g19so23008372ejc.9 for ; Tue, 18 Aug 2020 10:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=TxzeZiZTDI7ekkQ8ieEDHnmCAwnq0oHIylI1YY80hc4=; b=cwYERafzM3l4ak07RZqNtsTTVEShUB1uBapk36Sz9QQNfUXDMUSsD0OUF5OiuWgJcb yDSZ5ZJaRskq/FUxxyz7D3YIYvY1OH4PnzBRwzBI/DUZCvhUFKRXhdmshwQBsXhErphx OETeCKXw6C+x8ccgA6VJAbc5E8c2DjF77ZR3oo9diSrvV15LPB2GoITSQzyJijF2CJec PotOvAHB2ZAyMM2MrtO6Mfl/VlaZPpn6tggAo87w/K7MdH7zaKIRN/XfJlr1lUnCVkCv 60ypotTIaJI87ZpS7C7zbGhhlnJWa2j4rZ2NF/4Xu+047iDAeXgTSIN6MUS1mLnczmU1 mjEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=TxzeZiZTDI7ekkQ8ieEDHnmCAwnq0oHIylI1YY80hc4=; b=AyZPDV3T63+dyQ6SL4+w1WP4dH3AiOM6N9aGcZprHWmPyHNLD78gAS1p5Nzcd2meXK MJZ/q+965LAL5om1Zo5Y+C0OVwtNhd9sSUVz0r8r1CT9XZnHvl3A4p/XdgBylKECMo8r CpzurLw4+VC3NfvbJo/kbUf1PsjeRPn5mzu9yA0DFERG99WhHqHiaQ0Rly6PiBiKvRr1 301k0mtmf36Bo73Hk6zaH0yQBw0Zn+bL/EQjcTUIVCTmJUhWkJyiluSalttp3Xb/Z2N3 u38Em3lK3xJq/mo0hs1FGB+HSJP3Tkwd3YfAFmQH98WUaZsR2jkDQjgKug4dWcDOibSh dMvA== X-Gm-Message-State: AOAM531z3w/4XANm8+FQqaGcPiI4XEQOeJstmy+vMF52lFRyAa5eLWFz mb5S55s3aevyU8Hju3IR1KpF+ZpmbNDX15TnthlHwC8oRYs= X-Google-Smtp-Source: ABdhPJzvRqdzJhKFrmB20Ik94cvHFoCSIrLL++IP3mZVwq2pyDLUzuQCHUyUBuMDtMlVtS/lSAyydvAivhK9ccr6ZUs= X-Received: by 2002:a17:906:845:: with SMTP id f5mr327768ejd.34.1597771728196; Tue, 18 Aug 2020 10:28:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ryan Stone Date: Tue, 18 Aug 2020 13:28:37 -0400 Message-ID: Subject: Re: Is anybody using ng_pipe? To: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWHvP6w8cz4P4C X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=cwYERafz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2a00:1450:4864:20::633 as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [0.01 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_SHORT(0.01)[0.012]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::633:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; MAILMAN_DEST(0.00)[freebsd-net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 17:28:51 -0000 On Tue, Aug 18, 2020 at 1:17 PM Ryan Stone wrote: > 4. The table calculation had two integer truncation bugs and used the > wrong formula. I'm reasonably sure it would never calculate a > probability other than 0 due a 64-bit constant being truncated to > 32-bits. I've gone back and checked, and I was partially wrong on this point. I had gotten the idea that integer literals would be truncated to int, which is not true. The use of the wrong formula still means that packets are dropped at entirely the wrong rate, though.