From owner-p4-projects@FreeBSD.ORG  Sat May  9 13:21:24 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B611A106567B; Sat,  9 May 2009 13:21:23 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 749881065672
	for <perforce@freebsd.org>; Sat,  9 May 2009 13:21:23 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outU.internet-mail-service.net (outu.internet-mail-service.net
	[216.240.47.244])
	by mx1.freebsd.org (Postfix) with ESMTP id 5BF5C8FC25
	for <perforce@freebsd.org>; Sat,  9 May 2009 13:21:23 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id ED1E5BA48;
	Sat,  9 May 2009 06:21:37 -0700 (PDT)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (unknown [24.114.252.230])
	by idiom.com (Postfix) with ESMTP id 930DB2D6004;
	Sat,  9 May 2009 06:21:22 -0700 (PDT)
Message-ID: <4A058356.2080306@elischer.org>
Date: Sat, 09 May 2009 06:21:26 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
MIME-Version: 1.0
To: Marko Zec <zec@FreeBSD.org>
References: <200905091307.n49D7hN7057989@repoman.freebsd.org>
In-Reply-To: <200905091307.n49D7hN7057989@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Robert Watson <rwatson@freebsd.org>
Subject: Re: PERFORCE change 161828 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 May 2009 13:21:24 -0000

Marko Zec wrote:
> http://perforce.freebsd.org/chv.cgi?CH=161828
> 
> Change 161828 by zec@zec_tpx32 on 2009/05/09 13:07:41
> 
> 	Don't call if_dead() in if_detach() in options VIMAGE builds,
> 	given that we may wish to reattach the ifnet to another vnet
> 	after if_detach() is done, and if_dead() would render the
> 	ifnet useless.
> 	
> 	Pointed out by:	rwatson
> 
> Affected files ...
> 
> .. //depot/projects/vimage-commit2/src/sys/net/if.c#57 edit
> 
> Differences ...
> 
> ==== //depot/projects/vimage-commit2/src/sys/net/if.c#57 (text+ko) ====
> 
> @@ -950,8 +950,12 @@
>  
>  	/*
>  	 * Prevent further calls into the device driver via ifnet.
> +	 * XXX temporarily disabled in VIMAGE builds as we may need to
> +	 * to reattach the ifnet to another vnet.
>  	 */
> ++#ifndef VIMAGE
>  	if_dead(ifp);
> ++#endif
>  
>  	/*
>  	 * Remove link ifaddr pointer and maybe decrement if_index.


I may try to do the if_vmove() function today if I can get a P4 tree 
up on my laptop..