Date: Tue, 07 Jul 2020 13:10:34 +0000 From: "Tobias Kortkamp" <tobik@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: "Li-Wen Hsu" <lwhsu@FreeBSD.org> Subject: =?UTF-8?Q?Re:_svn_commit:_r541417_-_in_head:_audio/bambootracker_audio/z?= =?UTF-8?Q?ynaddsubfx_comms/nanovna-saver_comms/openzwave-devel_comms/te?= =?UTF-8?Q?lldus-core_comms/tlf_databases/arrow_deskutils/cairo-dock-plu?= =?UTF-8?Q?gins_devel/bossa_...?= Message-ID: <afdca732-9193-41da-88f6-61cdfc99d824@www.fastmail.com> In-Reply-To: <202007071227.067CRINg025699@repo.freebsd.org> References: <202007071227.067CRINg025699@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 7, 2020, at 12:53, Li-Wen Hsu wrote: > On Tue, Jul 7, 2020 at 8:27 PM Tobias Kortkamp <tobik@freebsd.org> wrote: > > > > Author: tobik > > Date: Tue Jul 7 12:27:18 2020 > > New Revision: 541417 > > URL: https://svnweb.freebsd.org/changeset/ports/541417 > > > > Log: > > Clean up some things > > > > Reported by: portscan and common sense > > Hi Tobias, > > I am somehow worried that this commit might cause some people's > objection. It does fix many things, which is great, but also: > - Changed (direct) dependency but not bump PORTREVISION (comms/nanovna-saver) I did not change any dependencies. What did I miss? > - Touched some style preference (print/pdfchain) The previous style causes active harm in readability and causes additional cognitve load on committers. See the commit message of r541362 for a direct example of this. Also style fixes are very much covered by the blanket. I quote chapter 5.5 from the Porter's Handbook: "We reserve the right to modify the maintainer's submission to better match existing policies and style of the Ports Collection without explicit blessing from the submitter or the maintainer. Also, large infrastructural changes can result in a port being modified without the maintainer's consent. These kinds of changes will never affect the port's functionality." https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-maintainer.html For pdfchain it IMHO should have been done before the initial import into the tree. > - Without notifying port's maintainer nor not having approval from porgmr > > Sorry that if I didn't notice there was a policy change that those > changes are also covered by blanket approval, and I'm a bit worried > about the last one, maybe the better way is file a PR with the patch > and let MAINTAINER have time to response (or use maintainer timeout > after two weeks)? If I have misinterpreted the blanket and if commits like this are indeed not covered by it, I would rather refrain from making commits like this in the future because I will not cause extra work for myself and file PRs for these trivial fixes. That is asking way too much. > BTW, what's "porscan"? I didn't notice that tool. Sounds useful and > can you tell me more about it? It's part of ports-mgmt/portfmt and will flag stuff like you see here. I run it regularly and results are published here: https://pkg.tobik.me/portscan/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?afdca732-9193-41da-88f6-61cdfc99d824>