From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Sep 7 16:40:07 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9DE0D16A41F for ; Wed, 7 Sep 2005 16:40:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B9DC43D58 for ; Wed, 7 Sep 2005 16:40:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j87Ge5LE016626 for ; Wed, 7 Sep 2005 16:40:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j87Ge5Vk016624; Wed, 7 Sep 2005 16:40:05 GMT (envelope-from gnats) Resent-Date: Wed, 7 Sep 2005 16:40:05 GMT Resent-Message-Id: <200509071640.j87Ge5Vk016624@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Adam Jette Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BEEC16A41F for ; Wed, 7 Sep 2005 16:36:36 +0000 (GMT) (envelope-from gsimpson@mail.chilisystems.net) Received: from mail.chilisystems.net (mail.chilisystems.net [216.47.168.82]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3211343D46 for ; Wed, 7 Sep 2005 16:36:36 +0000 (GMT) (envelope-from gsimpson@mail.chilisystems.net) Received: from mail.chilisystems.net (localhost [127.0.0.1]) by mail.chilisystems.net (8.12.5/8.12.5) with ESMTP id j87GaZoa036904 for ; Wed, 7 Sep 2005 12:36:35 -0400 (EDT) Received: (from gsimpson@localhost) by mail.chilisystems.net (8.12.5/8.12.5/Submit) id j87GaZwY036903; Wed, 7 Sep 2005 12:36:35 -0400 (EDT) Message-Id: <200509071636.j87GaZwY036903@mail.chilisystems.net> Date: Wed, 7 Sep 2005 12:36:35 -0400 (EDT) From: Adam Jette To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/85839: [maintainer-update] openradius .9.10 - fatal error amd64 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adam Jette List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2005 16:40:07 -0000 >Number: 85839 >Category: ports >Synopsis: [maintainer-update] openradius .9.10 - fatal error amd64 >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Wed Sep 07 16:40:05 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Adam Jette >Release: FreeBSD 4.11-RELEASE i386 >Organization: >Environment: System: FreeBSD >Description: I totally blew the last problem report, #85837, sorry. Joerg Wunsch discovered an error in openradius when run in FreeBSD under amd64 that causes it to core dump constantly. He has fixed this error with a patch and I'm submitting it for him until openradius fixes their code. >How-To-Repeat: >Fix: B --- openradius.patch begins here --- diff -ruN openradius.bak/files/patch-ringbuf openradius/files/patch-ringbuf --- openradius.bak/files/patch-ringbuf Wed Dec 31 19:00:00 1969 +++ openradius/files/patch-ringbuf Wed Sep 7 11:31:47 2005 @@ -0,0 +1,62 @@ +--- common/ringbuf.c.orig Mon Feb 14 16:10:51 2005 ++++ common/ringbuf.c Tue Aug 30 13:55:42 2005 +@@ -355,7 +355,7 @@ + ssize_t ring_count(RING *r, RINGCNTFUNC func, ...) + { + va_list ap; +- ssize_t len, ret; ++ ssize_t len, ret = 0; + + len = ring_maxget(r); + +@@ -363,37 +363,41 @@ + + /* There is data available */ + +- va_start(ap, func); +- + if (r->r + len <= r->size) { + + /* Message ends before end of buffer */ + + /* peek at single part, return whatever the + closure returns. */ +- return func(r->buf + r->r, len, 0, ap); ++ va_start(ap, func); ++ ret = func(r->buf + r->r, len, 0, ap); ++ va_end(ap); + } + else { + + /* Message doesn't end before end of buffer */ + + /* peek at first part, till end of buffer */ ++ va_start(ap, func); + ret = func(r->buf + r->r, r->size - r->r, 0, ap); ++ va_end(ap); + + if (ret < r->size - r->r) { + /* Satisfied by first part; return whatever + the closure gave us. */ +- return ret; + } +- +- /* peek at rest, from start of buffer */ +- return ret + func(r->buf, len - (r->size - r->r), +- ret, ap); ++ else { ++ /* peek at rest, from start of buffer */ ++ va_start(ap, func); ++ ret += func(r->buf, len - (r->size - r->r), ++ ret, ap); ++ va_end(ap); ++ } + } + } + + /* No data available, return 0. */ +- return 0; ++ return ret; + } + + --- openradius.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: