From owner-freebsd-arch@FreeBSD.ORG Tue May 31 13:34:46 2011 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5EFD21065670; Tue, 31 May 2011 13:34:46 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id DEB808FC08; Tue, 31 May 2011 13:34:45 +0000 (UTC) Received: by gyg13 with SMTP id 13so2604228gyg.13 for ; Tue, 31 May 2011 06:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LVSmB85qYlHDaL3fZa8ZoC5JsBnOZaedd7+vTmFvHlU=; b=wZvG5a/CyefhwZEVJiRJSXCcbU1qhoq4r5qAHCSry+zQY8mmP2o8oUzsTySD0v58zK hYMSuRy9To5SJtHf3BMyJGqPN/6U0d/ho+LOHCvzZEd7XqyqjPbNdnRKK7kLL6iujbsD LgAlAb8UgQuzhuPjdY+8Aer+UjKuynFzEK8B8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=lKhSKv0dkbePOQdP6Qzp/Yql4T4SkMuXPSbFIKV4JauzlBe8DLFySBz+Y2H3YAIH1h JkdB9kaTbqnamB0LDbXkXjRMgGNDLs6GNK/hEshrJL41Kn7vjCayx1s5mJBAILfbDu6l mMUAVq19sCyEvPf9Jn+pFQ+g5G6ljRilEqWSI= MIME-Version: 1.0 Received: by 10.236.161.194 with SMTP id w42mr6771364yhk.237.1306848885146; Tue, 31 May 2011 06:34:45 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.103.136 with HTTP; Tue, 31 May 2011 06:34:44 -0700 (PDT) In-Reply-To: <4DE4D41B.1000000@FreeBSD.org> References: <4DD3F662.9040603@FreeBSD.org> <4DD54C18.8050305@FreeBSD.org> <4DDA8B2A.6010500@FreeBSD.org> <4DDD2B34.5070702@FreeBSD.org> <4DE4D41B.1000000@FreeBSD.org> Date: Tue, 31 May 2011 09:34:44 -0400 X-Google-Sender-Auth: ArqOaQt3weQvcGly6vcpJn3F6AM Message-ID: From: Attilio Rao To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-current@freebsd.org" , "freebsd-arch@freebsd.org" Subject: Re: [rfc] remove hlt_cpus et al sysctls and related code X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2011 13:34:46 -0000 2011/5/31 Andriy Gapon : > on 29/05/2011 06:06 Attilio Rao said the following: >> 2011/5/28 Attilio Rao : >>> 2011/5/25 Andriy Gapon : >>>> The patch is here: >>>> http://people.freebsd.org/~avg/cpu-offline-sysctl.diff >>>> It should implement the strategy described above. >>>> >>> >>> I don't see the point in keeping alive mp_grab_cpu_hlt() and >>> supporting, actually. >>> >>> On the top of your patch I made some modifies that use directly >>> ap_watchdog() in cpu_idle() which I think is better for the time >>> being: >>> http://www.freebsd.org/~attilio/avg_rem_cpuhlt.diff > > Yes, I agree, thank you. > >>> If you are happy with it, just commit as long as Garrett tests that. > > > OK. =C2=A0Waiting for test feedback. > >>> On a second round of changes we can discuss mp_watchdog and eventual >>> removal / improvements to it. >> >> I almost forgot: this change would also require an UPDATE entry, where >> you explicitly mention the "new" way to deal with CPUs. Use your >> prefer wording. > > Sure. =C2=A0Thank you! > > BTW, I guess there would be no reason to MFC this change? You mean no reason to not MFC it? In general, I think that users may expect those sysctls to be alive (IMHO we should consider sysctls to be part of the userland API) so that we can add some more, but we should not axe them. So probabilly MFC is not the best option here. Attilio --=20 Peace can only be achieved by understanding - A. Einstein