From owner-svn-src-head@FreeBSD.ORG Sat Nov 1 00:54:10 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 41E8D855; Sat, 1 Nov 2014 00:54:10 +0000 (UTC) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 020B1D54; Sat, 1 Nov 2014 00:54:09 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id ey11so8689180pad.35 for ; Fri, 31 Oct 2014 17:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=j121buUndlL354zFkCva1wNdNn1Yw/O4DsxkMpMy6gY=; b=J/N49T7jX1B0iuV/wnP5zTbrom2A1IIlMVEjN/3GSGHV4SjQBcslL9/jTlz838dHqM UU5hFrGMLgp16dQ8aGN6Hb/v6eSeL+KQVNZUDI6aO44765jrnCme7iVPSSZ8VsRXW1S4 esSR4/SUtmUy45La1T6yD1cLowWWWsg/uyVsB7QpXQdDh6U0NKhMr2fM5nSEYkoHRp6q 3cnsi0BL08ThliXyJrRWw7bfA9lRWYrd1CWj+7cVUGvQ6dWfWXnVEbtr11J37XYgoN7H PqDJwL3Ruyum8LZqY6lJ5F7YQcLHZmutCl31ow9lkVRoqgdFbqGaCZ73JIN0jNT7D/92 F4Ow== X-Received: by 10.70.37.101 with SMTP id x5mr28566927pdj.24.1414803249225; Fri, 31 Oct 2014 17:54:09 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:34d4:4abd:64bb:590a? ([2601:8:ab80:7d6:34d4:4abd:64bb:590a]) by mx.google.com with ESMTPSA id ri9sm10980947pbc.5.2014.10.31.17.54.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 31 Oct 2014 17:54:08 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_DF1385D1-9A8E-43B3-A633-733B5E8017FC"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r273919 - head/etc/rc.d From: Garrett Cooper In-Reply-To: <86bnor9202.fsf@nine.des.no> Date: Fri, 31 Oct 2014 17:54:07 -0700 Message-Id: <0577B462-91E9-4E46-BF9E-085B50EDE09C@gmail.com> References: <201410312220.s9VMKRaO096404@svn.freebsd.org> <86bnor9202.fsf@nine.des.no> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Nov 2014 00:54:10 -0000 --Apple-Mail=_DF1385D1-9A8E-43B3-A633-733B5E8017FC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 On Oct 31, 2014, at 17:51, Dag-Erling Sm=F8rgrav wrote: > Xin LI writes: >> Log: >> rc.d/geli should not depend on random, as the attach functionality >> do not require additional entropy to function. >>=20 >> It would create a circular dependency (not immediately obvious: >> geli provides 'disks' and requires 'random' as of r273872, >> 'random' requires 'FILESYSTEMS', 'FILESYSTEMS' requires 'root', >> 'root' requires 'swap', and finally 'swap' requires 'disk'). >=20 > My first instinct was: shouldn't rcorder warn about this? It turns = out > that it does, but in a very cryptic fashion: >=20 > des@nine ~head/etc/rc.d% svn up -qr273871 =20 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > des@nine ~head/etc/rc.d% svn up -qr273872 =20 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > rcorder: Circular dependency on file `zfs'. > rcorder: Circular dependency on provision `mountcritlocal' in file = `zfs'. > rcorder: Circular dependency on provision `mountcritlocal' in file = `var'. > rcorder: Circular dependency on provision `mountcritlocal' in file = `FILESYSTEMS'. > rcorder: Circular dependency on provision `root' in file = `FILESYSTEMS'. > des@nine ~head/etc/rc.d% svn up -qr273919 =20 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > des@nine ~head/etc/rc.d%=20 rcorder errors are indeed cryptic/confusing. I can quickly add a = testcase for this if you like (basically check for all the scenarios = that need to be covered via /etc/rc). Does that sound good? Thanks! --Apple-Mail=_DF1385D1-9A8E-43B3-A633-733B5E8017FC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUVC8vAAoJEMZr5QU6S73eH4AH/0x96qlsz3AdSPeCxTjNU1cE 7xJPuln401K/ORTt28vnzyw8uPQ2ldvfzqmwuR5ijSl3o1lW/jMWMPbwCuSkFP2w xgviOSsqzdqhPifOb5VCoRP95kuCyq9+k9Cdrs9Q3jlC7ijBAla7cxYCGtRK2xQW qgVI4v/a+/P1Q+rHS2XC5fh9qBXUH/U7Ybq5CrAfPCh57BpUfWtArmYHyGubcDew m/c172ERAiG035IJeTdoBC/dX2NMCOwQiy3wxNkSq7OCMeLirv04GK5tOOZIHaaZ HXPBcyFQfAtB5ugILC4/rjIWznaTMZg3+n6WdJs6643fJ2qLCeSHlHlmhjohoZY= =AsJe -----END PGP SIGNATURE----- --Apple-Mail=_DF1385D1-9A8E-43B3-A633-733B5E8017FC--