From owner-svn-src-all@FreeBSD.ORG  Sun May 22 16:24:55 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8C0CF106564A;
	Sun, 22 May 2011 16:24:55 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 4996B8FC13;
	Sun, 22 May 2011 16:24:55 +0000 (UTC)
Received: from [10.0.0.63] (63.imp.bsdimp.com [10.0.0.63])
	(authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p4MGOpXe091443
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Sun, 22 May 2011 10:24:53 -0600 (MDT) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <20110522093302.GA2638@mole.fafoe.narf.at>
Date: Sun, 22 May 2011 10:24:51 -0600
Content-Transfer-Encoding: 7bit
Message-Id: <03BABBB2-56C2-48DD-898A-B25A8E4040F2@bsdimp.com>
References: <201105152003.p4FK3tnS050889@svn.freebsd.org>
	<20110522093302.GA2638@mole.fafoe.narf.at>
To: Stefan Farfeleder <stefanf@FreeBSD.org>
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Sun, 22 May 2011 10:24:53 -0600 (MDT)
Cc: svn-src-head@FreeBSD.org, "Andrey V. Elsukov" <ae@FreeBSD.org>,
	svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: svn commit: r221972 - head/sys/geom/part
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 May 2011 16:24:55 -0000


On May 22, 2011, at 3:33 AM, Stefan Farfeleder wrote:

> On Sun, May 15, 2011 at 08:03:55PM +0000, Andrey V. Elsukov wrote:
>> Author: ae
>> Date: Sun May 15 20:03:54 2011
>> New Revision: 221972
>> URL: http://svn.freebsd.org/changeset/base/221972
>> 
>> Log:
>>  Add a sysctl kern.geom.part.check_integrity for those who has corrupt
>>  partition tables and lost an ability to boot after r221788.
>>  Also unhide an error message from bootverbose, this would help to
>>  easier determine the problem.
> 
> So, what's the point of this check? It breaks mounting of all my USB
> drives.  Everyone now has to set this sysctl?

Personally, I think it can be just deleted.  I think it is wrong...

Warner

> da0 at umass-sim0 bus 0 scbus6 target 0 lun 0
> da0: <Kingston DT 101 G2 PMAP> Removable Direct Access SCSI-0 device 
> da0: 40.000MB/s transfers
> da0: 15304MB (31342592 512 byte sectors: 255H 63S/T 1950C)
> GEOM_PART: integrity check failed (da0, MBR)
> 
> Stefan
> 
>