From owner-freebsd-bugs@FreeBSD.ORG Sun Nov 21 16:50:33 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 59B7816A4D4 for ; Sun, 21 Nov 2004 16:50:24 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B58B43D54 for ; Sun, 21 Nov 2004 16:50:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iALGoO0H020620 for ; Sun, 21 Nov 2004 16:50:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iALGoOWo020619; Sun, 21 Nov 2004 16:50:24 GMT (envelope-from gnats) Resent-Date: Sun, 21 Nov 2004 16:50:24 GMT Resent-Message-Id: <200411211650.iALGoOWo020619@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michael Hambly Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED7CE16A4CE for ; Sun, 21 Nov 2004 16:48:08 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC44643D4C for ; Sun, 21 Nov 2004 16:48:08 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iALGm8xT079850 for ; Sun, 21 Nov 2004 16:48:08 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id iALGm8Oo079849; Sun, 21 Nov 2004 16:48:08 GMT (envelope-from nobody) Message-Id: <200411211648.iALGm8Oo079849@www.freebsd.org> Date: Sun, 21 Nov 2004 16:48:08 GMT From: Michael Hambly To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: misc/74205: Patch for Connection.cc in the mysqlcppapi port needs to check for higher versions of MySQL. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2004 16:50:33 -0000 >Number: 74205 >Category: misc >Synopsis: Patch for Connection.cc in the mysqlcppapi port needs to check for higher versions of MySQL. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Nov 21 16:50:24 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Michael Hambly >Release: 5.3 >Organization: Blackbird Software Design Ltd. >Environment: 5.3-RELEASE FreeBSD 5.3-RELEASE #0: Fri Nov 5 04:19:18 UTC 2004 root@harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: The mysqlcppapi port fails to compile against MySQL version 4.1.5 because the mysql_shutdown function parameters changed in version 4.1.3. The patch for this already exists as /usr/ports/databases/mysqlcppapi/files/patch-mysqlcppapi-Connection.cc. Problem - the patch checks for specific versions of MySQL as follows: +#if ( MYSQL_VERSION_ID == 40103 ) || ( MYSQL_VERSION_ID == 50001 ) This check does not catch higher versions of MySQL which also contain the altered mysql_shutdown function. >How-To-Repeat: cd /usr/ports/databases/mysql41-server make install clean cd /usr/ports/databases/mysqlcpapi make install clean >Fix: The patch should check for higher version increments of MySQL as follows: +#if ( MYSQL_VERSION_ID >= 40103 && MYSQL_VERSION_ID < 50000 ) || ( MYSQL_VERSION_ID >= 50001 ) >Release-Note: >Audit-Trail: >Unformatted: